search

Substra / hlf-k8s

Initializes an Hyperledger Fabric network (orchestrator distributed mode)
https://docs.substra.org
Apache License 2.0
31 stars 20 forks source link

Use substra.Client new login method #42

Closed jmorel closed 4 years ago

jmorel commented 4 years ago

Companion PR to https://github.com/SubstraFoundation/substra/pull/138

I updated the script because it made use of the substra client but upon closer look it seems this is outdated code altogether (hardcodes the docker-compose config, only watches for traintuples and testtuples, etc.)

Maybe I should remove it altogether?

ClementGautier commented 4 years ago

I would remove it altogether if it's not used/maintained. Meanwhile I see no downside of merging this.

samlesu commented 4 years ago

Same as Clement, if it's not used/maintained I would be in favour of removing it.

jmorel commented 4 years ago

Replaced by #43