search

Substra / hlf-k8s

Initializes an Hyperledger Fabric network (orchestrator distributed mode)
https://docs.substra.org
Apache License 2.0
31 stars 20 forks source link

Extract values for skaffold #93

Closed Kelvin-M closed 4 years ago

Kelvin-M commented 4 years ago

In order to have a simpler skaffold file and add the possibility to deploy with helm only, we extract helm values from skaffold file into separate values files.

@natct10 Do we need to update the documentation for that part ?

AurelienGasser commented 4 years ago

After discussion, new proposed directory structure:

/
/skaffold.yaml
/dev
/dev/values
/dev/serviceAccounts
/dev/skaffold-xxx.yaml
/dev/test-xxx.sh
ClementGautier commented 4 years ago

I would, for myself, named them like that:

examples/
-- 2-orgs-policy-any/
---- skaffold.yaml
---- values/
-- 4 orgs-policy-majority
...

examples looks more explicit than dev for me. Whatever solution you choose I'm :+1: this :100: times ;)

Kelvin-M commented 4 years ago

@ClementGautier Both are good for me ! @AurelienGasser what do you think about the skaffold files located in an examples folder ?

AurelienGasser commented 4 years ago

I think @ClementGautier's suggestion makes sense

We can rename dev/ to examples/ and leave everything as is (leave skaffold.yaml at the root)

I think whatever naming scheme we chose is not going to be 100% accurate/consistent here.

If we have to choose between a dev/ and an examples/ folder (there's some overlap between the two), then I think examples/ makes more sense: people looking at the repo are probably interested in examples,

It's probably easier (from a user's perspective) to have a few dev tools/resources in examples/ than having the examples live in a dev/ folder

Kelvin-M commented 4 years ago

I made updates according your comments @AurelienGasser and @ClementGautier