Substra / substra-documentation

Documentation of the Substra software
https://docs.substra.org/
Apache License 2.0
21 stars 10 forks source link

docs: Update k3s-args flags, from `--no-deploy` to `--disable` #285

Closed jjerphan closed 1 year ago

jjerphan commented 1 year ago

When running the k3-create.sh script, I get the following warnings and fatal error:

WARN[0001] warning: encountered fatal log from node
k3d-k3s-default-server-0 (retrying 0/10):
ctime="2023-02-23T14:21:02Z" level=fatal msg="no-deploy flag is
deprecated. Use --disable instead."

[...]

WARN[0006] warning: encountered fatal log from node
k3d-k3s-default-server-0 (retrying 9/10):
ctime="2023-02-23T14:21:07Z" level=fatal msg="no-deploy flag is
deprecated. Use --disable instead."

ERRO[0007] Failed Cluster Start: Failed to start server
k3d-k3s-default-server-0: Node k3d-k3s-default-server-0 failed to
get ready: error waiting for log line `k3s is up and running` from
node 'k3d-k3s-default-server-0': stopped returning log lines: node
k3d-k3s-default-server-0 is running=true in status=restarting

It seems that k3s deprecating the --no-deploy flag makes creating the Kubernetes cluster fail.

This proposes using the --disable flag instead, which seems to resolve the issue.

Local deployment setup information:

$ k3d --version
k3d version v5.4.7
k3s version v1.25.6-k3s1 (default)

$ k3s --version
k3s version v1.25.6+k3s1 (9176e03c)
go version go1.19.5

$ docker --version
Docker version 23.0.1, build a5ee5b1

$ skaffold version
v2.1.0

$ helm version
version.BuildInfo{Version:"v3.5", GitCommit:"", GitTreeState:"",
GoVersion:"go1.16.6"}
guilhem-barthes commented 1 year ago

Hi, thanks for your contribution but the same change has been merged some minutes ago (https://github.com/Substra/substra-documentation/pull/286 ) ! It was really a matter of minutes.

jjerphan commented 1 year ago

Rah, not the first race condition that I've seen. Thanks for the heads-up, @guilhem-barthes!