chore: use `Client.wait_compute_plan` - Githubissues

Substra / substra-documentation

Documentation of the Substra software

https://docs.substra.org/

Apache License 2.0

21 stars 10 forks source link

chore: use `Client.wait_compute_plan` #327

Closed guilhem-barthes closed 1 year ago

guilhem-barthes commented 1 year ago

Related issue

Summary

Centralize wait_task and wait_compute_plan, and re-use the implementation added in substra through the other components.

Notes

Fixes FL-1052

Please check if the PR fulfills these requirements

[x] If necessary, the changelog has been updated
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)
[x] The commit message follows the conventional commit specification

linear[bot] commented 1 year ago

FL-1052 move `wait_task` & `wait_compute_plan`

# Context Currently we have 3 imlementations to wait for compute tasks/ compute plans: * [substrafl](https://github.com/Substra/substrafl/blob/main/tests/utils.py) * [substra-tests](https://github.com/Substra/substra-tests/blob/main/substratest/client.py) * [substra-documentation](https://github.com/Substra/substra-documentation/blob/main/substrafl_examples/get_started/run_mnist_torch.py) # Specification # Acceptance criteria Having these features defined once in `substra` and the previous implementations removed.