search

SubstrateChess / pallet-chess

The Unlicense
11 stars 6 forks source link

Extend unit testing for elo-ranking #36

Open AlexD10S opened 1 year ago

AlexD10S commented 1 year ago

I changed the name of the test check_elo_player_aborts with check_elo_player_draw because what is actually testing is the scenario of a draw (I change the players ELO ranking too, but just for testing purposes).

I add a test check_elo_stronger_abandon where the stronger player abandon and therefore loses to see if in case of abandom the ELO ranking is updating property too.

Moliholy commented 1 year ago

Looks good to me. I however can't trigger the merge when the CI passes 😞

bernardoaraujor commented 1 year ago

@Moliholy just added you as a contributor to the repo, let me know if you got the invite.

Feel free to merge.