search

Subterfuge-Revived / Remake-Backend

Server side validation and API
Creative Commons Zero v1.0 Universal
10 stars 1 forks source link

Response inconsistency between auth methods #35

Open pisanovo opened 4 years ago

pisanovo commented 4 years ago

Semantically equivalent responses should be syntactically equivalent, this makes working with responses in the Core easier.

https://github.com/Subterfuge-Revived/Remake-Backend/blob/ea0192bda8bc46604fd5713e8bb20be40b165232/app/Http/Controllers/Auth/RegisterController.php#L74-L81

https://github.com/Subterfuge-Revived/Remake-Backend/blob/ea0192bda8bc46604fd5713e8bb20be40b165232/app/Http/Controllers/Auth/LoginController.php#L68-L75