SubtitleEdit / plugins

Plugins for Subtitle Edit
GNU General Public License v3.0
87 stars 43 forks source link

Update american english to British english #24

Open ivandrofly opened 9 years ago

ivandrofly commented 9 years ago
xylographe commented 9 years ago

https://www.dropbox.com/s/obmm9pczhom4bfp/UsGb.xml?dl=1

ivandrofly commented 9 years ago

Nice :smile: thx @xylographe

xylographe commented 9 years ago

Oops, there were some surplus spaces left. Fixed it. (same link)

ivandrofly commented 9 years ago

:+1:

niksedk commented 8 years ago

@ivandrofly : is this ok?

ivandrofly commented 8 years ago

:+1:, but there are some word which should be removed

xylographe commented 8 years ago

There is a duplicate for "yogurt" which can be translated to English as either yoghurt or (rarely used) yoghourt.

Some of the commented translations, like archaeological and battleaxe, should probably be activated.

xylographe commented 8 years ago

See preview

TMDaines commented 8 years ago

When can we expect this long list of words to be added to the downloadable US to UK English plugin? It looks great.

TMDaines commented 8 years ago

Alternatively, could anybody share how I could add this word list to the plugin myself?

xylographe commented 8 years ago

The word list is included (as a resource) in the DLL (AmericanToBritish.dll). You would have to compile the source code, after replacing AmericanToBritish\DLL\WordList.xml.

TMDaines commented 8 years ago

Looks like I am going to have to learn something new in that case.

It would great to see an updated plugin.

xylographe commented 8 years ago

You can try AmericanToBritish.dll from this folder.

xylographe commented 8 years ago

BTW you probably should be aware that AmericanToBritish is not exactly the most sophisticated tool. It will make silly mistakes, like:

ivandrofly commented 8 years ago

I added support to local-words-list :) https://github.com/SubtitleEdit/plugins/commits/americanBritish /cc @xylographe @TMDaines

PS: Any suggestions?

TODO:

TMDaines commented 8 years ago

@xylographe Thanks for the file. I appreciate its shortcomings but it is the same with all the error proofing tools that the software offers. The user needs to sense check stuff and filter out the suggested changes that are erroneous.

@ivandrofly a "local words manager" sounds sweet. Would love to see it implemented.

xylographe commented 8 years ago

@ivandrofly Local list is a very good idea.

Please, use the name AmericanToBritish.xml for clarity, because the list will be in the Plugins folder together with AmericanToBritish.dll.

The existence of a local list should disable the use of the built-in list. Or, there could be a global attribute to disable the built-in list, for example <Words OverWrite="True"> or <Words NoBuiltIn="True">. The default for this optional attribute would be "False".

ivandrofly commented 8 years ago

@TMDaines I think the plugin is ready, can you test it? https://github.com/SubtitleEdit/plugins/releases/download/v.1.1/AmericanToBritish.zip

TMDaines commented 8 years ago

Plugin works great with the built in list.

I've spotted one correct entry. It should be "mailman" to "postman". Currently they are the wrong way around.

xylographe commented 8 years ago

Ty, @TMDaines.

Should one also add mail carrier to postman, and letter carrier to postman? (Oxford Dictionaries)

TMDaines commented 8 years ago

Meh. I would just let "mail" be picked up by "post" and leave it like that.

TMDaines commented 8 years ago

"Sneakers" to "trainers" definitely needs to be added.

xylographe commented 8 years ago

Added sneaker/trainer to PR #43

marb99 commented 8 years ago

it possible add a funtion to "does not allow add duplicate words to the list"?

TMDaines commented 8 years ago

Another entry would be

US: windshield UK: windscreen

xylographe commented 8 years ago

Thank you, @TMDaines.

Added in commit 8305923c72d0d409ab0665d6a957c78338aee14a DLLs in AmericanToBritish.7z over here.

I must confess, I had never heard of windshield before. :)

TMDaines commented 8 years ago

"mediaeval" and "biassed" can both be removed from British English. Neither would be used nowadays. @xylographe

xylographe commented 8 years ago

Thank you, @TMDaines.

Removed in commits 06937c6aaebfce5d935d3e353fc9e4ca44183526 and 7cce6960b1a32f9a01482d859dd6e8e8bca084ae. DLLs in AmericanToBritish.7z over here.