SubtitleEdit / subtitleedit

the subtitle editor :)
http://www.nikse.dk/SubtitleEdit/Help
GNU General Public License v3.0
8.76k stars 910 forks source link

Arabic auto detection #2441

Closed OmrSi closed 7 years ago

OmrSi commented 7 years ago

In case you forgot

private static readonly string[] AutoDetectWordsArabic = { "من", "هل", "لا", "في", "لقد", "ما", "ماذا", "يا", "هذا", "إلى", "على", "أنا", "أنت", "حسناً", "أيها", "كان" };

niksedk commented 7 years ago

Hm, I've tried like 10 different Arabic subs from subscene + yifysubtitles - and somehow the old version works but not the new? (I might do something wrong as I've auto-detected ANSI encoding - when will ppl learn to use UTF-8!?)

It's fine to add more words to the list...

OmrSi commented 7 years ago

I don't know why they like to use ANSI, Man. The reason escapes me. Anyway, I upload my subtitles in UTF-8 It's better. Here is my page: https://subscene.com/u/766688 Use the tv shows subtitles, because I translate the movies with 2 other translators and they make me upload it with ANSI.

Thanks for all your hard work. :)

OmrSi commented 7 years ago

and all the translators upload their subtitles in ANSI Arabic Windows-1256 In case you would like to use other subtitles

OmrSi commented 7 years ago

The programme doesn't auto detect windows-1256 Arbian translators use Windows-1256 or UTF-8, nothing else. I'm guessing you got the words for the old version from another ANSI encoding?

OmrSi commented 7 years ago

Have you had the chance to work on this?

niksedk commented 7 years ago

@OmrSi: Yes, I probably got the words from a bad code page, so re-tried with "Windows-1256" and it works now :)

Could you add a few more words? (common words with 3 or more letters are best)

OmrSi commented 7 years ago

private static readonly string[] AutoDetectWordsArabic = { "من", "هل", "لا", "في", "لقد", "ما", "ماذا", "يا", "هذا", "إلى","على", "أنا", "أنت", "حسناً", "أيها", "كان", "كيف", "يكون", "هذه, "هذان", "الذي", "التي", "الذين", "هناك", "هنالك" };

OmrSi commented 7 years ago

I think those are more than enough. 😃

niksedk commented 7 years ago

thx :)

niksedk commented 7 years ago

Included in latest beta: https://github.com/SubtitleEdit/subtitleedit/releases/download/3.5.3/SubtitleEditBeta.zip