Release 3.5.15

[niksedk]

Some nice fixes and some nice new features - and a huge amount of minor improvements!

@Flitskikker added sentence continuation style - see https://github.com/SubtitleEdit/subtitleedit/pull/4108

Also, this version brings some sought after features: "Tesseract 5 Alpha", waveform for video with no audio, shortcuts F4-F12 customizable, more improvements for "Batch convert", improvements for "Fix common errors".

Check the full change log here: https://raw.githubusercontent.com/SubtitleEdit/subtitleedit/master/Changelog.txt

Please do give latest beta a run and report any bugs here :) https://github.com/SubtitleEdit/subtitleedit/releases/download/3.5.14/SubtitleEditBeta.zip

TODO:

• [x] Test Continuation style
• [x] Test "Batch convert"
• [x] Test Fix common errors
• [x] Test OCR
• [x] General testing (+ fixing bugs)

[OmrSi]

You've been doing a lot of work. Thank you. :)

[ghost]

Great. I will definitely give this a try. Now, I took the liberty to update the Greek translation. Translation.zip

Also, I came across this strange message on beta 334, while trying to create a waveform. I tried immediately for a second time, and there was no issue. Strange.

[xylographe]

Updated Greek translation applied in commit 1772a156c7625d6a1e4294bd806702c050bedfc8.

[ghost]

Another error message, while trying to create a waveform. This time, on latest beta.

[Signy13]

OCR tested with Tesseract 3 and 5 - everything looks OK (Linux, Wine 5.0, .NET 4.0). BTW: thank you very much for improvement of the mpv library error poppup - it is a big help (even if there is no possibility to copy the link) - I downloaded the mpv library manually and it really works better than VLC.

[niksedk]

@Lero91: About ffmpeg, could you check if the .wav file actually exists when you get this error? (last two lines in msgbox) Also, does this error appear instantly or after a while?

@Signy13: Can you see more with a tool like Fiddler about the download fail? Is Wine/SE not using TLS 1.2 ?

About shortcuts and the Windows Key - I presume that SE should ignore all shortcuts if a Win-key is down, right?

The * in the titlebar indicating that the current file has changes - should that be before or after the file name? (I see notepad has it before...)

[niksedk]

SE should now ignore shortcuts when the Windows-Key is pressed ( commit https://github.com/SubtitleEdit/subtitleedit/commit/12d5feb5b81af75710e3040a71bc7eb93211f56c )

[ghost]

@niksedk: No, the wav file doesn't exist, when I get the message, and it appears instantly. I say it's mostly random. Also, about the video player settings, when I uncheck the boxes for mute, stop and fullscreen options, they are checked back, when I restart the programme. Is this intentional?

[Signy13]

@niksedk I went through a common Wine log file found some errors: 0093:fixme:ras:RasEnumConnectionsW (06E4F5F8,0032DC64,0032DC68),stub! 0093:fixme:ras:RasEnumConnectionsW RAS support is not implemented! Configure program to use LAN connection/winsock instead! I have not found any solution for this error on the Internet. Then I tested SubtitleEdit on Wine + .NET 4.7 and the downloading works now. So there might be someting wrong with .NET 4.0... However, it is still useful then SubtitleEdit can provide useful information when some download is not working :)

About the * in the titlebar indicating that the current file has changes:

• Mousepad has the * before,
• Pinta after,
• TED notepad after,
• Aegisub before,
• abiword before.

But probably before is better, because when there is:

1. *
2. name of the file
3. then name of the program,

in the bar bellow you chan see:

1. icon of program,
2. *
3. and the rest

one can quickly recognize that there is something unsaved...:

[niksedk]

Beta updated: https://github.com/SubtitleEdit/subtitleedit/releases/download/3.5.14/SubtitleEditBeta.zip

Fixed titlebar so it's now * + name of the file + Subtitle Edit (like Notepad), thx @Signy13 :)

@Lero91: Also fixed some of the video player buttons, thx :)

[Flitskikker]

@niksedk One thing I found a while ago but maybe falls under "Test OCR". I have some pre-OCR'ed .srts that have a lowercase L instead of an uppercase i, in uppercase text:

In FCE, there is "Fix uppercase 'i' inside lowercase words". Would it be easy to also add "Fix lowercase 'L' inside uppercase words"?

[OmrSi]

@niksedk Maybe "after" should be after the name and not at the end? Also, there is no indication for the original. My idea is, before means here and here:

And after means here and here:

[borifax]

Thanks for fixing the error when the files with the .mts extension are not loaded (chat). A similar error occurs with the file extension .eac3 when I trying to load it into waveform (SE does not "see" it).

[OmrSi]

@niksedk Can you hide for Arabic in FCE: Add period after lines where next line start with uppercase letter Start with uppercase letter after paragraph Start with uppercase letter after period inside paragraph Start with uppercase letter after colon/semicolon Fix uppercase 'i' inside lowercase words

They don't have a meaning in Arabic as it doesn't have upper and lowercase characters.

EDIT: It can wait since it doesn't have a negative effect, it just doesn't do anything.

[uckthis]

Why F11 & F12 default shortcuts were removed?

[niksedk]

@uckthis: They should not be... was a bug in an earlier beta version. But shortcuts F4-F12 can be customized now.

[uckthis]

@niksedk I already have Start and End time keys set. F11&F12 just gave the option of having multiple shortcuts doing the same thing. In my case both of them were used for different scenarios. My Set Start is Alt+[, which works effectively when I'm syncing an imported text, but during proofreading F11 was much easier as it's just one key. But if more people want F11 and F12 free to be assigned, then I'll make do.

[niksedk]

@uckthis: A solution could be having double shortcuts - like for "F9" Would that help or be more confusing?

[uckthis]

@niksedk Yes, that would surely solve the problem. "Add another" next to Clear button in shortcut page, that would work too. That would also allow to add multiple shortcuts for every command. And maybe colorize the new shortcut to differentiate. Let's see what others have to say.

[Signy13]

@niksedk Yes, that would surely solve the problem. "Add another" next to Clear button in shortcut page, that would work too. That would also allow to add multiple shortcuts for every command.

The new button between "Update" and "Clear" is a nice solution.

[borifax]

Is it possible to set the time with an accuracy of 0.01 sec. after each click on the "waveform" field? The accuracy is currently 0.001 sec.

[OmrSi]

@uckthis I had the same opinion when this was done, but he said people are asking to customize F4-F12 so I made do. But I think adding an "Add another" is a bit complicated, he would have to edit the code for each shortcut, I'm guessing.

[uckthis]

@OmrSi I don't know programming at all, but I think it's going to be one condition that will apply all.

[OmrSi]

@uckthis Based on what I've seen, he'd have to add another parameter to each condition of the shortcuts and would have to make it duplicate every entry in the settings file.

[uckthis]

@OmrSi If it's that much trouble, then let's just forget it.

[OmrSi]

@Flitskikker I just got to test the sentence continuation style with Arabic. You need to add the Arabic comma ، and add the Arabic question mark ؟ as a line ending. The line ends with a question mark, which means it's a full sentence.

The first line ends with a comma, I'm using None, dots for pauses so it shouldn't be removed or replaced.

[OmrSi]

And something in this file, in the tags, is causing FCE to crash: Bloodshot 2020 BluRay (Colored).zip

[Ouroboros1995]

Great work. Best program for subtitles.

[Flitskikker]

@OmrSi Thanks for the report and the file, going to look into it.

Would the continuation style make sense at all for Arabic at the moment? Looks like it's adding the trailing dots - that should be at the ending - at the front of the sentence because it's RTL.

[OmrSi]

@Flitskikker In general, SE works with the file before reversing. So, one should do FCE then reverse the file, other rules apply this way also. You can treat it as it is before reversing. :D

[Flitskikker]

@OmrSi I have fixed the crash. Wasn't specific to Arabic, it was caused by stripped { } tags, so it would have crashed on other languages too. So good catch!

Could you explain the reversing? The logic relies a lot on the actual sentence continuation, so it detects beginnings and ends of sentences. For example, it checks if the first character is a capital letter. Wouldn't that fail on Arabic, because the first character is a dot or question mark?

[OmrSi]

Hmm. Well, we translate the file then reverse it, so it can be used before reversing and it should work fine. You have two ways of reversing which could be found in the Edit menu. But as I said, it can be used before reversing. How would it work? Well, the same as English but without the case of the letter. If the line doesn't end with anything, it checks the gap and works based on that. If the file is already reversed, the translator can just uncheck the option. You just need to add the Arabic question mark as a line ending and the Arabic comma as an alternative comma.

EDIT: @Flitskikker if it needs a lot of work, or if it will take a lot of time, please ignore it, disable it for Arabic as a default, I really don't think many Arabic translators will use it anyways, they usually go with Netflix's style and there is no need to change it.

[OmrSi]

@niksedk Using the remove all formatting shortcut is making the list go to the top. It might have something to do with https://github.com/SubtitleEdit/subtitleedit/pull/4126

[Flitskikker]

@OmrSi I added some basic support (it just converts the comma and question mark before and after, because there's a lot going on internally based on the comma). Maybe you can pull it locally and test if it works? https://github.com/SubtitleEdit/subtitleedit/pull/4150

[OmrSi]

@Flitskikker It's working well. :D Just one thing. Can you make it just ignore the line if it was all in quotes? We use it for on-screen text, we write the subtitle in quotes and don't end it with a dot.

[moob158]

@Flitskikker the continuation style should not replace the comma in the end of line, the comma is a kind of continuation.

and the tooltip "lorem ipsum" in continuation style combobox should be remove, the tooltip is useful for non english read the entire content "drop down" of combobox because the combobox is too small for read the entire content of it in others languages "SE translations"

[uckthis]

Remove unneeded space doesn't work in italics. Example: I happen to have the blood of an ancient family .

It doesn't fix the space before period.

[Flitskikker]

@OmrSi Great! Could you send me a test file that contains on-screen text?

@moob158 Which continuation style do you have set? When it's set to none, it keeps the comma. When it's set to "Dots", for example, any sentence that ends with a comma is seen as a continuing sentence. Thus, it will apply the continuation style. Effectively, replacing the comma with dots. This is what happens in every subtitle I've checked (for languages that use dots).

I'm not sure what you mean regarding the tooltip. It uses lorem ipsum for all SE languages. Could you please explain?

[niksedk]

@OmrSi: thx, after 'remove all formatting' first selected line should be selected (if lines were removed). @uckthis: thx, remove spaces issue should be fixed now.

Beta updated: https://github.com/SubtitleEdit/subtitleedit/releases/download/3.5.14/SubtitleEditBeta.zip

[ghost]

Further translation improvements and updates. Keep up the good work, Nikolaj. This release is shaping up really great. Translation.zip

[niksedk]

@Lero91: thx, and thx for the translation update: https://github.com/SubtitleEdit/subtitleedit/commit/5853c3bf17e0c98e16f52a8cfb2e0f52467e9107

[OmrSi]

@Flitskikker Sure. These all are On-screen: On-Screen.zip

[OmrSi]

@niksedk You seem ready for the new version. I hope you can just wait a little for the last sentence continuation style pull request for Arabic from @Flitskikker :)

[Flitskikker]

@OmrSi Thanks. Two questions:

• Should it only detect " ?
• Wouldn't these quotes be used for actual quotes in some cases? If so, how to differentiate a screen text vs a continuing quote?

[OmrSi]

Yes, we only use ". Well, the difference is that we end a normal quote with a punctuation mark, usually a dot, while we leave the on-screen text without a dot at the end. I know there would still be some room for error because we don't have casing, but the translator would just have to check those, and adding this rule will lower the number a lot.

[OmrSi]

Another thing that might help, if the line before the quoted line ends with a comma, then it's a quote without a doubt.

[Flitskikker]

@OmrSi I've added some logic: https://github.com/SubtitleEdit/subtitleedit/pull/4152 If a subtitle is an insert / screen text (wrapped in quotes and ends with nothing) it will uncheck the fix by default. Currently a hardcoded rule for Arabic; if it works I can add it to the settings UI in the next version.

Let me know how it works!

[OmrSi]

@Flitskikker Activating this is causing all lines to be unchecked in Arabic for some reason:

Other than that, it's working. :D

[Flitskikker]

@OmrSi Could you please pull again and try it again with that option checked? It should now ignore it for languages that don't have upper/lower case.

[moob158]

@Flitskikker

I can't read the entire content, translation is cut, the tooltip is useful for read this