SubtitleEdit / subtitleedit

the subtitle editor :)
http://www.nikse.dk/SubtitleEdit/Help
GNU General Public License v3.0
8.59k stars 897 forks source link

MP4 subtitles don't get fully converted #6331

Closed thehiss-guy closed 2 years ago

thehiss-guy commented 2 years ago

Hi! Encountered weird issue - subtitles ripped from CBS only get converted halfway, even though they're full. Can you please fix this issue? Thanks!

Attaching file in question

stream [stream].en-US.mp4.zip

Conversion cuts of at

467 00:19:09,756 --> 00:19:12,000 Wait a minute, Deac. Check this.

niksedk commented 2 years ago

Thx for the file :)

Should work in latest beta now: https://github.com/SubtitleEdit/subtitleedit/releases/download/3.6.7/SubtitleEditBeta.zip

thehiss-guy commented 2 years ago

Almost. now it cuts off at 31 minute :(

thehiss-guy commented 2 years ago

I think it has to do with SE automatically merging strings it thinks are the same

thehiss-guy commented 2 years ago

Or maybe ad breaks

thehiss-guy commented 2 years ago

Almost. now it cuts off at 31 minute :(

I think it has to do with SE automatically merging strings it thinks are the same

Or maybe ad breaks

On Sat, Oct 15, 2022 at 9:03 PM Nikolaj Olsson @.***> wrote:

Thx for the file :)

Should work in latest beta now: https://github.com/SubtitleEdit/subtitleedit/releases/download/3.6.7/SubtitleEditBeta.zip

— Reply to this email directly, view it on GitHub https://github.com/SubtitleEdit/subtitleedit/issues/6331#issuecomment-1279773491, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATIQPESCYQIWRLANDD3FE23WDLIWJANCNFSM6AAAAAARFYGDEE . You are receiving this because you authored the thread.Message ID: @.***>

niksedk commented 2 years ago

Almost. now it cuts off at 31 minute :(

I'm sure that SE got the last text - and no lines were merged.

thehiss-guy commented 2 years ago

Converting with mp4box seems to extract fully

stream [stream].zip

niksedk commented 2 years ago

Thx, I see the difference now... I will look into it (mp4 is not an easy format to read)

niksedk commented 2 years ago

OK, mp4 files normally have time codes matching with texts, e.g. 8 time codes and 8 texts. Well, I thought so at least. It seems that time codes can cover multiple texts when time codes have the optional size field:

image See https://github.com/niksedk/Mp4Browser

I will try to implement this is SE now and see how it works...

niksedk commented 2 years ago

@LucretiaAudrey: OK, how is this? https://github.com/SubtitleEdit/subtitleedit/releases/download/3.6.7/SubtitleEditBeta.zip Are texts okay? Are time codes okay?

thehiss-guy commented 2 years ago

Thanks a lot! Now it seems to extract fully, although time codes might be a bit skewed after some position. I'll check it today

thehiss-guy commented 2 years ago

Yeah, sadly timings are screwed(

niksedk commented 2 years ago

Hm, if I extract the webvtt with mp4box via mp4box -raw 1 stream [stream].en-US.mp4 I get very equal results ... a lot of differences ;)

image

Left is SE - right is mp4box

niksedk commented 2 years ago

OK, no differences now in latest beta between SE/mp4box: https://github.com/SubtitleEdit/subtitleedit/releases/download/3.6.7/SubtitleEditBeta.zip

image

Thx for the interesting file :)

thehiss-guy commented 2 years ago

Thank YOU for constantly improving SubtitleEdit!