search

SubtitleEdit / subtitleedit

the subtitle editor :)
http://www.nikse.dk/SubtitleEdit/Help
GNU General Public License v3.0
8.73k stars 908 forks source link

Found another IMSC1.1 Bug #8169

Closed ryzen88 closed 6 months ago

ryzen88 commented 6 months ago

Hey, its me again.

I found another issue with the new IMSC1.1 profile. It often does not notate the frame rate multiplier in the subtitle file even when filling it in with the properties tab.

With a blanc new subtitle not, it can remove it when importing something that has it notated. Not per definition always but more often than not.

niksedk commented 6 months ago

Could you provide some examples? (you can attach .zip files here on Github)

ryzen88 commented 6 months ago

test package.zip I have added some screenshots and the bug and sub file, and demonstration with a new sub, but noticed that is also happens with subs that already have the value in the subtitle and it just clears them. Also added a normal TT that does not have the issue.

Specifically its about the ttp:frameRateMultiplier="1000 1001" when having subs of 23.976

ryzen88 commented 6 months ago

I also found that when the Title is annotated with the Titel name go here </ttm:title> in the original subtitle for example a normal TT. The title gets removes in the conversion to IMSC. With the normal TT you have the option to manually insert the title name, but not with the IMSC TT. It would be cool if there is a title name in the original that it preserves it.

niksedk commented 6 months ago

I also found that when the Title is annotated with the ttm:title Titel name go here </ttm:title> in the original subtitle for example a normal TT. The title gets removes in the conversion to IMSC. With the normal TT you have the option to manually insert the title name, but not with the IMSC TT. It would be cool if there is a title name in the original that it preserves it.

Do you have a sample IMSC 1.1 document with a title? I have a hard time finding this in the spec: https://www.w3.org/TR/ttml-imsc1.1

ryzen88 commented 6 months ago

Example_IMSC1.zip

niksedk commented 6 months ago

OK, I've added the title here: https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.5/SubtitleEditBeta.zip

I will close this as. you also have a similar issue.