SubtitleEdit / subtitleedit

the subtitle editor :)
http://www.nikse.dk/SubtitleEdit/Help
GNU General Public License v3.0
8.58k stars 895 forks source link

[Feature request] Batch mode for burn-in feature #8210

Closed LeonCheung closed 5 months ago

LeonCheung commented 6 months ago

If it is possible to implement, please consider adding this, since it's really magic when generating tens or even more files, say (TV/short video series):

A humble UI mockup (GIF):

demo

After preparing all subtitle files (with the same file names in the same path(s) of the video source), all chosen files could share the same setting, and start burning with a single click. ⚡

niksedk commented 6 months ago

Something like this? https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.5/SubtitleEditBeta.zip

MbuguaDavid commented 6 months ago

Something like this? https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.5/SubtitleEditBeta.zip

Subtitles are not burned into the video. :( It's just creating a new video without the burned in subtitle. Also, there's no way to get out of Batch Mode. Once you click on Batch mode the Batch interface is always on.

Batch Mode Icon gone

LeonCheung commented 6 months ago

Brilliant solution! One button, two functions. 👍 Even better than I imagined. XD

Feedback/ideas for now:

  1. Error occurs when trying to remove item. (☑ resolved thx!) image

  2. When trying to cancel, something happened like this: (☑ resolved thx!) image

  3. When there are both SRT and ASSA files detected (same filename), ASSA should be used by default, because in 99.9% cases the ASSA file is generated from SRT for burning purpose. (☑ resolved thx!)

  4. Allow remove by using Delete key. (☑ resolved thx!)

  5. Better show the resolution column as well, for better QC and decisionmaking. (☑ resolved thx!)

  6. Maybe also support custom text other than "_new", e.g. user may prefer adding something like "v2", "English" "small_size", or even other languages. Maybe putting it here: (☑ resolved thx!)

image

  1. Shorten the total time display: (☑ resolved thx!) image

  2. When the list is long, we can't see the full status, so either we don't close the burning tool window, or showing things like " {num} of {total} files are successfully converted". Not sure about this... just FYI. (☑ resolved thx!)

  3. Inspired by 8, sometimes we want to convert to different versions, say, different resolutions/quanities. Instead of quitting the tool by clicking "OK", it would be nice to allow go back and give a chance to burn with another set of parameter based on the same batch. Maybe adding one more button like this:

image

  1. Allow selecting a different output path. This is very useful for, say, TV series, with each episode located in different path as individual project, but they are expected to be output all together into one folder for final delivery. (☑ resolved thx!)

  2. Also nice to allow burning without subtitles in Batch mode. (even subtitles are found)(☑ resolved thx!)

  3. Display file count (for the list, making sure nothing is missed BEFORE burning), maybe like this:

image

niksedk commented 6 months ago

Thx for testing guys :)

Beta updated: https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.5/SubtitleEditBeta.zip

LeonCheung commented 6 months ago

@niksedk A few issues with beta 60:

  1. The pick / remove subtitle file option now updates to the Size column.
  2. The text "Converted" now updates to Subtitle File column.
  3. It seems I was allowed to add the same video to the list many times. Maybe it could better be avoided?
niksedk commented 6 months ago

thx @LeonCheung :)

Beta updated: https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.5/SubtitleEditBeta.zip

It's still allowed for the same video file multiple times - in case ppl would like that, e.g. with different subtitles.

MbuguaDavid commented 6 months ago

When burning videos with different resolutions, it seems the resolution set in the Video section e.g. 1280 x 720 is what is used. This means that a vertical video of say 1080 x 1920 is going to be converted to the resolution set on the interface. This also applies if a video is of a higher resolution 1920 x 1080.

Is it possible to work with the resolution of the video? Vertical videos are getting converted to landscape videos. :(

Video Resolutions - Batch Burn

niksedk commented 6 months ago

@MbuguaDavid: Do you mean an option to keep the existing resolution?

MbuguaDavid commented 6 months ago

@MbuguaDavid: Do you mean an option to keep the existing resolution?

Yes! Maintain the resolution of the video I'm burning subtitles to.

niksedk commented 6 months ago

OK, I've tried to make this possible here: image

https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.5/SubtitleEditBeta.zip

LeonCheung commented 6 months ago

It's still allowed for the same video file multiple times - in case ppl would like that, e.g. with different subtitles.

Ah, right, haven't thought about it, making good sense then. 👍 Btw, just updated my second post, would you help evaluate some of the rest, especially # 6 if it makes some sense?

MbuguaDavid commented 6 months ago

OK, I've tried to make this possible here: image

https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.5/SubtitleEditBeta.zip

This is much better and it works. Thanks! For some strange reason, I'm not getting the subtitles burned into any video I add. hmmm

LeonCheung commented 6 months ago

OK, I've tried to make this possible here: image https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.5/SubtitleEditBeta.zip

This is much better and it works. Thanks! For some strange reason, I'm not getting the subtitles burned into any video I add. hmmm

@MbuguaDavid Did it work with previous version? And have you tried a clean installation? Not sure if it's something about parameters with ffmpeg lib on your side. Anyway, just try a clean installation.

MbuguaDavid commented 6 months ago

OK, I've tried to make this possible here: image https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.5/SubtitleEditBeta.zip

This is much better and it works. Thanks! For some strange reason, I'm not getting the subtitles burned into any video I add. hmmm

@MbuguaDavid Did it work with previous version? And have you tried a clean installation? Not sure if it's something about parameters with ffmpeg lib on your side. Anyway, just try a clean installation.

I'm working with fresh beta downloads. It worked yesterday. I'm not sure why the subs are not getting burned in but let me see if it's going to work as it should.

LeonCheung commented 6 months ago

@niksedk Ooops, sorry, for some reason it wasn't updated well, one sec.

LeonCheung commented 6 months ago

Awkward... now it's updated. 😅 But wow, you already did it!

niksedk commented 6 months ago

Beta updated: https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.5/SubtitleEditBeta.zip

image

MbuguaDavid commented 6 months ago

Beta updated: https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.5/SubtitleEditBeta.zip

image

Nice! Is it possible to have an option to save in a custom folder as well?

LeonCheung commented 6 months ago

@MbuguaDavid Seems like the same thing to # 10 in my post. @niksedk BTW, the use source resolution feature doesn't work in beta 70, just nothing happend.

LeonCheung commented 6 months ago

A few more to bother:

  1. It's amazing that the list keeps rolling while genrating so that we could monitor which file is currently burning, that's so nice. I just think it's even better to have a {num} of {total} indicator somewhere to know how the whole process goes, e.g.: image

  2. Something happens when I resize the window:

image

LeonCheung commented 6 months ago

And audio files should not be allowed to add.

LeonCheung commented 6 months ago

Another interesting by-product of the tool could be allow extracting audio file for convictive purposes. I mean, there could be three options: Video only, Audio only, Video+Audio.

I know extracting audio might be kind of beyond the true purpose of this tool, and we can always count on other tools. However, audio is often expected for subtitle workflow when considering performance, file size, and easy collaboration with others, as well as protecting visual copyright/privacy when outsourcing.

niksedk commented 6 months ago

New beta with more output settings: https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.5/SubtitleEditBeta.zip

image

LeonCheung commented 6 months ago

Nice design, thx so much!

And it cannot be switch back to 0x0, I guess:

demo

LeonCheung commented 6 months ago

Reslution display difference: res display issue

MbuguaDavid commented 6 months ago

Reslution display difference: res display issue res display issue

When you set "use source resolution" it respects the different resolutions.

E.g. This is the 1st file. It automatically sets the resolution to 1080 x 1920 1080

And once it moves to the next file of a different resolution 1920 x 1080, it sets that resolution as well.

1920 Thanks!

LeonCheung commented 6 months ago

Hmm, don't know how it looks in the latest beta. IMHO the 0x0 diplay could be a bit difficult for users to understand. Maybe a toggle that disables the resolution input field (turned grey) would make more sense?

niksedk commented 6 months ago

Hmm, don't know how it looks in the latest beta. IMHO the 0x0 diplay could be a bit difficult for users to understand. Maybe a toggle that disables the resolution input field (turned grey) would make more sense?

Yes, you're right. Not a good UI... hopefully a little better here: https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.5/SubtitleEditBeta.zip

LeonCheung commented 6 months ago

Hi @niksedk,

  1. Regarding this issue:

res display issue

I found it only occurs on those videos that were generated by SE's burning tool... Tested videos generated by other apps, the resolution displayed is correct. FYI

  1. BTW, shall we ignore adding audio to the list? image

  2. A small tweak needed: image

LeonCheung commented 6 months ago

@niksedk UPDATE: I found that I made a stupid mistake by simply selecting one of the resolution presets and forgot that they are vertical TikTok videos! 😂 You know, the current presets are all for legacy aspects. (Sidenote: A possible improvement for the preset list needed for that? Or, allow to switch Height and Width values?)

However, later I found that it doesn't help with the incorrect res display issue. Luckily it's only about display on UI, the file itself is correct.

niksedk commented 6 months ago

@LeonCheung: Do we have a bug with the resolution? I did not understand the issue...

Fixed a few issues + added 1080x1920 resolution - I guess that's the most common?

https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.5/SubtitleEditBeta.zip

LeonCheung commented 6 months ago

@niksedk Sorry for not making that clear, and thanks for the update. I think it's better we only focus on one issue each time, from now on. :)

About the resolution display issue, here is how to recreate:

  1. Use the burning tool to burn one or more videos, try using different resolution presets, e.g. from 1920x1080 to 960x720.
  2. After burning complete, add the generated video to the list, and see if the resolution displayed is correct.
niksedk commented 6 months ago

@niksedk Sorry for not making that clear, and thanks for the update. I think it's better we only focus on one issue each time, from now on. :)

About the resolution display issue, here is how to recreate:

1. Use the burning tool to burn one or more videos, try using different resolution presets, e.g. from 1920x1080 to 960x720.

2. After burning complete, add the generated video to the list, and see if the resolution displayed is correct.

Is it only with .mp4 files?

LeonCheung commented 6 months ago

Is it only with .mp4 files?

I think so. All previous tests are based on mp4 files. Just tried mov, mkv, avi, they seem working fine. So, what happened? 😂

niksedk commented 6 months ago

Seems better here: https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.5/SubtitleEditBeta.zip

But it could be some ffmpeg size parameter that should be different or is missing... I will look into this. I normally just use mkv.

LeonCheung commented 6 months ago

@niksedk Yes, working fine just very slow loading this time, especially when loading multiple videos. 😢 (turns out for mp4 only, approx 1 sec per file)

BTW, I think we'd better start a new issue for any other possible issues, because this thread is a bit too long. The resolution issue will be the last one here if you don't mind. :)

amir3dsmax commented 5 months ago

working fine but font change does not applied