SubtitleEdit / subtitleedit

the subtitle editor :)
http://www.nikse.dk/SubtitleEdit/Help
GNU General Public License v3.0
8.48k stars 895 forks source link

New TTS issues after the update #8348

Closed cvrle77 closed 5 months ago

cvrle77 commented 5 months ago

TTS goes from quiet to normal loudness, and so is the quality. Lower volume has horrible quality, while loudest part have the best quality, not sure how to describe it, but sibilants are muddy like they've gone through horrible limiter, and are also muddy from compression, but everything sound at the edge of being distorted.

Second issue: Output went from good wav to bad mp3. Return wav output.

Third issue is: if there's only a single line of subtitle that needs to be TTS-ed, program gets stuck when I press generate.

4th issue, previous versions now can't generate anything, program simply gets stuck on generate. 195 works, none after that.

Sending you output in zip file so you can check what I'm talking about. Another 3000 credits destroyed. :/ fml

image

Plazma kolač sa jagodama.zip

niksedk commented 5 months ago

OK, we're back to wav... did that help? https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.5/SubtitleEditBeta.zip

cvrle77 commented 5 months ago

Nope, here's the message, there's 3 wav, 3 mp3 files, and silence.wav, which is how it should look before it merges all together. So, this is a message that I get, when I hit OK in 'Review audio clips' window, to merge all files in one.

I've also tested one-liner TTS and it doesn't crash, but drops same message, when I want to merge.

image

niksedk commented 5 months ago

Ah, yes, sorry - should just be fixed: https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.5/SubtitleEditBeta.zip

cvrle77 commented 5 months ago

Oh my god, you jump scared me with this comment, LOL

cvrle77 commented 5 months ago

Yes, one-liner fixed, now I can generate a single line without crashing, quality is back, and it is merging files properly.

niksedk commented 5 months ago

Phew, nice :)

cvrle77 commented 5 months ago

But we're now also back to mono -.- Can we have an option like checkbox, to force stereo output when needed? Not to have it as default, mono default is good, Force Stereo Output as an option is best (BUT DO NOT CHANGE TO MP3!!) :D

BlueBlue7891 commented 5 months ago

The issue I mentioned earlier has also been resolved, thank you very much for your efforts @niksedk

niksedk commented 5 months ago

"Force stereo" is in latest beta now: https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.5/SubtitleEditBeta.zip

cvrle77 commented 5 months ago

Nope, still mono. I mean, option is there, but doesn't work. image

BlueBlue7891 commented 5 months ago

The option for forced stereo cannot be selected

image

cvrle77 commented 5 months ago

The option for forced stereo cannot be selected

You can't select stereo, if there's no subtitle. image

BlueBlue7891 commented 5 months ago

I have loaded the subtitle file, and I have found the reason. When I did not load the video file, this option cannot be selected

niksedk commented 5 months ago

The "Stereo" option is only for the final video... why is this needed?

cvrle77 commented 5 months ago

Stereo option doesn't work. I can select it, but output is still mono. It is needed for stereo image panning in post processing, and it is time consuming to create stereo from mono in any other way. Creating it at the source is fastest way possible.

niksedk commented 5 months ago

Stereo option should work in latest version - both for final audio file + for final optional merged video file: https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.5/SubtitleEditBeta.zip

cvrle77 commented 5 months ago

But now we are back to mp3, instead of wav, for stereo. :S

niksedk commented 5 months ago

But now we are back to mp3, instead of wav, for stereo. :S

Better with wav?

cvrle77 commented 5 months ago

Wav is lossless, mp3 is losing quality, each time it is recompressed.

niksedk commented 5 months ago

Beta updated: https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.5/SubtitleEditBeta.zip

cvrle77 commented 5 months ago

Now it's wav, but mono again :D image

niksedk commented 5 months ago

He, you can right-click on the media file name in SE and get the media info:

image

Seems to be stereo here...

cvrle77 commented 5 months ago

I am getting split results here:

I if uncheck 'Add audio to video file' I get mono wav output. If I check that option, I get stereo wav output, and video output in mkv container with mono sound. Also, option 'Force stereo' checkbox status doesn't get saved like other two options 'Review audio clips' and 'Add audio to video file (new file)', when I leave the window, or close the app. Whenever I open the window 'Text to speech', force stereo is unchecked.

Regarding your previous reply, I am not sure, where to click to see media properties in SE, when generated files aren't loaded in SE??

image

niksedk commented 5 months ago

Thx, beta updated: https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.5/SubtitleEditBeta.zip

cvrle77 commented 5 months ago

Well, it's hot mess now. 'Add audio to video file' now doesn't output video. Both options give same result - only audio file. Force stereo doesn't get saved. File is named filename_stereo_stereo.wav But yes, output is stereo. image

niksedk commented 5 months ago

Hm, seems ffmpeg gives stereo per default... not too sure, but beta updated: https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.5/SubtitleEditBeta.zip

cvrle77 commented 4 months ago

I am not sure what is going on, but 'force stereo' option is completely gone, and sound is mono.

image

niksedk commented 4 months ago

I'm getting stereo here...

Audio output encoding could be a setting in a future version, but ATM I'm readying for SE 4.0.6,

cvrle77 commented 4 months ago

If you are getting stereo, then I found another bug or you uploaded wrong version of beta, because I've tried several times, and it's always mono. image image