search

SubtitleEdit / subtitleedit

the subtitle editor :)
http://www.nikse.dk/SubtitleEdit/Help
GNU General Public License v3.0
8.72k stars 908 forks source link

Hearing Impaired removal small bug. #8756

Closed RAMoynihan closed 2 months ago

RAMoynihan commented 2 months ago

Hi folks,

I think I found a small bug in the 'remove HI' function. I've shown the issue in the capture below.

All of the test subtitles contain the interjection "Mm" which is supposed to be removed, and lines 2 through 4 also include the text "MAN:" which should also be removed.

The issue presents itself in line 3. I would have expected the result to be a single line saying only "Text", but it retains the "MAN:" part plus a trailing period ('.') character at the end. To test whether the trailing period in line 3 was triggering the issue I tried a new subtitle (line 4) without the trailing period, but the issue remains.

I just happened to notice this and thought that I should report it.

Regards, Bob

Capture

RAMoynihan commented 2 months ago

What a dope! I messed up by trying to simplify this bug before reporting it. When I look again at what I posted above I can clearly see the "Text MAN:" isn't a valid case for "Only if text is uppercase" removal. So I mistakenly edited out the bug before reporting it. Sorry about that. I'll try again with the ACTUAL bug.

RAMoynihan commented 2 months ago

Here's what I should have presented originally.

You can see in line 2 below how the entire line "MAN: Mm." is removed as expected. But if that same text appears as the 2nd line in a 2-line subtitle (as in line 4 below) the "MAN:" part doesn't get removed. I would have expected the result to be simply "Text".

Capture2

niksedk commented 2 months ago

SE does not support badly formatted lines, with e.g. missing periods.