search

SubtitleEdit / subtitleedit

the subtitle editor :)
http://www.nikse.dk/SubtitleEdit/Help
GNU General Public License v3.0
8.89k stars 915 forks source link

Italic tags written incorrectly #8851

Closed Boulder08 closed 2 months ago

Boulder08 commented 2 months ago

Looking at the OCR matches, the italics detection has worked correctly, but the tags in the output SRT file are wrong.

image

142
00:11:54,255 --> 00:11:56,257
-Yes?
LEO [OVER PHONE]:They'<i>re here.</i>

batman_s01e19_en.zip

niksedk commented 2 months ago

Thanks, hopefully now fixed in latest beta: https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.8/SubtitleEditBeta.zip

Boulder08 commented 1 month ago

Looks like there still some tuning to be made. Similar case where the detection is good but the starting tag is not in the correct place.

image

walkingdead_s10e22_en.zip

niksedk commented 1 month ago

Hm, I cannot re-create this in latest beta: https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.8/SubtitleEditBeta.zip

Boulder08 commented 1 month ago

Just tested, and yes, works with that release. Funny how the initial issue was fixed by the previous linked release but this one just now :)

niksedk commented 1 month ago

Ah, my first fix was a little buggy...