SubtitleEdit / subtitleedit

the subtitle editor :)
http://www.nikse.dk/SubtitleEdit/Help
GNU General Public License v3.0
8.68k stars 908 forks source link

'Regenerate' TTS window #8869

Open cvrle77 opened 1 month ago

cvrle77 commented 1 month ago

Hi there,

I’d like to request a feature enhancement in TTS part of the SE, that would really improve workflow efficiency. Currently, when I regenerate a subtitle line, SE automatically returns me to the main window. However, I often need to fine-tune the line further, sometimes doing it over 20 times for a single line, and it would be much more convenient to stay in the Regenerate window until I’m happy with the result. This would allow me to play the line and regenerate it as needed, without having to go back and forth between windows, which can be quite cumbersome.

Additionally, I noticed the button is labeled "Edit" but performs a "Regenerate" function. It might be more intuitive to standardize the name as "Regenerate" for consistency.

Thank you for considering this enhancement, and I appreciate your help in making this process smoother!

image

niksedk commented 1 week ago

How is this? https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.8/SubtitleEditBeta.zip

image

What OS are you using?

cvrle77 commented 5 days ago

Absolutely GREAT! Using Windows 10. But now you invoked another option on the main window that must be in Regenerate window😁 image

niksedk commented 4 days ago

OK, new beta up: https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.8/SubtitleEditBeta.zip

image

cvrle77 commented 4 days ago

Oh my gawd... new options just saved me 1/3rd of the time I've used to spend on regenerating and trying to get adequate expression in certain sentences. The variety of expressions in a single sentence went from few to infinite in a whiff. Probably the best addon in TTS section - ever. THANK YOU!!!

cvrle77 commented 4 days ago

Um, weird things start to happen if I stretch the window 😁 image

cvrle77 commented 4 days ago

I'm experiencing an issue with the "Stop" button when used in the middle of a sentence. When I press "Stop" mid-sentence, it seems to disrupt the audio playback. The last sentence repeats, as though I pressed "Play" again, and the sound quality becomes slightly choppy. This choppiness is subtle, so I'm not sure if the audio came that way from ElevenLabs, but initially, it wasn’t garbled.

I’m also wondering if this might be similar to a previous issue I encountered where double-clicking the "Play" button caused stuttering playback.

Additionally, when I press the "Edit" button to enter regeneration mode, I expect the audio playback to stop automatically. However, if "Auto-Continue" is checked, the audio keeps playing in the background, so I have to exit, stop the sound manually, and then return to regeneration mode.

Finally, when pressing the "Stop" button, it doesn't immediately halt the playback; instead, it finishes playing the last line. This can be frustrating.

Thank you for looking into this!

niksedk commented 4 days ago

OK, tried to improve the play stuff here: https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.8/SubtitleEditBeta.zip Let me know how it works.

cvrle77 commented 3 days ago

Tested, works good. No double sound in any scenario, sound stops when I go to regenerate, stop button stops the sound, all there. Thank you!