search

SubtitleEdit / subtitleedit

the subtitle editor :)
http://www.nikse.dk/SubtitleEdit/Help
GNU General Public License v3.0
8.87k stars 916 forks source link

"Change casing" > "Only change all uppercase lines" does not redo lines that are all uppercase but also contain tags #8903

Closed Hlsgs closed 1 month ago

Hlsgs commented 1 month ago

This happens both in the main interface and when batch converting. The example I've come across is the basic <i> tag.

Example line that does not get changed: <i>LOREM IPSUM</i>

However, this line does get changed: <I>LOREM IPSUM</I>

So, I guess it's a matter of filtering out the tags before doing the all uppercase check.

niksedk commented 1 month ago

Thx for reporting this :)

Should hopefully now be fixed in latest beta: https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.8/SubtitleEditBeta.zip

Hlsgs commented 1 month ago

Thx for reporting this :)

Should hopefully now be fixed in latest beta: https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.8/SubtitleEditBeta.zip

Tested main interface, batch convert and CLI batch convert and this is fixed, however, there are a copule of related issues I've noticed:

  1. CLI /RedoCasing ignores the Only change all uppercase lines option that is set and retained in the batch convert window(pre-beta said option was not retained and had to be set each time one opened said window)
  2. When not using the Only change all uppercase lines option SE presents lines that contain names with proper casing as if they were lowercase, as in the following picture: 1