search

SuddenH4X / awesome-app-rating

An Android library providing a dialog, which asks the user to rate the app or give feedback. You can also use the library to show the Google in-app review easily under certain conditions.
Apache License 2.0
231 stars 40 forks source link

Duplicate dialogs. #33

Closed Monabr closed 3 years ago

Monabr commented 3 years ago

The problem is if we rotate the screen - dialog will appear one more time upon the old one.

SuddenH4X commented 3 years ago

Hi @Monabr,

thanks for opening the issue. I couldn't reproduce the duplicate dialogs. Are you using the latest library version? Do you show it from fragment or activity? And can you please share me your rating dialog building code?

Monabr commented 3 years ago

I am show it from activity. The problem is that this works from onCreate, and your dialog doesn't make any checks after .showIfMeetsConditions(), so it will be show one more time if i didn't click, for example, "later".

Monabr commented 3 years ago

for now i am using this code to fix this behavior if (supportFragmentManager.findFragmentByTag(AppRating::class.java.simpleName) == null)

SuddenH4X commented 3 years ago

Thanks again for opening this issue. I've fixed it within #40.