search

SuddenH4X / awesome-app-rating

An Android library providing a dialog, which asks the user to rate the app or give feedback. You can also use the library to show the Google in-app review easily under certain conditions.
Apache License 2.0
231 stars 40 forks source link

Fatal exception #82

Closed dvaoru closed 1 year ago

dvaoru commented 2 years ago

After I start using this library in my app, I'm getting this exception in Firebase crash reports:
Fatal Exception: java.lang.RuntimeException Parcelable encountered IOException writing serializable object (name = com.suddenh4x.ratingdialog.dialog.DialogOptions)

But I don't know how it affects on user experience.

SuddenH4X commented 1 year ago

Hi @dvaoru, I can't reproduce this issue. Can you share more information please?

dvaoru commented 1 year ago

Hello.

Thank you for your attention. I have solved this issue for myself, by making com.suddenh4x.ratingdialog.dialog.DialogOptions class not Serializable but Parcelable. I did not reproduce the issue too, but I got a lot of this on Crashlytics. After I make DialogOptions Parcelable and update my app, I don't have any troubles.

Thank you for your project, it is really helpful!

Best regards Dvaoru.

сб, 21 янв. 2023 г. в 18:50, SuddenH4X @.***>:

I can't reproduce this issue. Do you have a full stacktrace and more information for me? (like how often this crash occurs, which devices, ...)

— Reply to this email directly, view it on GitHub https://github.com/SuddenH4X/awesome-app-rating/issues/82#issuecomment-1399276769, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANP44QST67J23H6C2OBWRC3WTQAVZANCNFSM6AAAAAAR4KQ2QA . You are receiving this because you authored the thread.Message ID: @.***>

SuddenH4X commented 1 year ago

Alright, thanks for sharing your solution!