search

SuddenH4X / awesome-app-rating

An Android library providing a dialog, which asks the user to rate the app or give feedback. You can also use the library to show the Google in-app review easily under certain conditions.
Apache License 2.0
231 stars 40 forks source link

Added option to show bottom sheet instead of dialog #89

Open rosenpin opened 1 year ago

rosenpin commented 1 year ago

Added the setBottomSheet function that causes the initial rating dialog to pop up as a bottom sheet instead of as a dialog.
Bottom sheets are less intrusive and more in line with Google's own rating library so I figured it would be a good fit.

Screenshot_20230821_114241_awesome-app-rating Example App

P.S. I have 2 other branches that are based on this one in my fork https://github.com/rosenpin/awesome-app-rating/tree/feature/skip-prompt https://github.com/rosenpin/awesome-app-rating/tree/feature/confirm-on-rating-selected

It would have been better to separate them so I could open 3 PRs but this bottom sheet one caused some relatively significant changes in the DialogManager class and I wanted to avoid later conflicts.
So for now, I will wait for this PR to be merged before opening the 2 other PRs.

rohitjakhar commented 1 month ago

why this branch not merge yet? This is good feature that we need.