Sude- / lgogdownloader

LGOGDownloader is unofficial downloader to GOG.com for Linux users. It uses the same API as the official GOG Galaxy.
https://sites.google.com/site/gogdownloader/
Do What The F*ck You Want To Public License
696 stars 67 forks source link

Feature Request: ZIP Compression and meeting naming convention for GameVault #282

Open DrakeHamString opened 1 week ago

DrakeHamString commented 1 week ago

Hi there, I want to include my GOG Library in GameVault

For this you need ZIP files and they need to meet the naming convention:

Title (Version) (EarlyAccess) (GameType) (NoCache) (ReleaseYear).zip

Like: Far Cry 6 (v1.5.0) (2021).zip

So lgogdownloader has to fetch the "real" names of the games and include it into the ZIP's file names. At the End the whole download folder should contain only ZIP files and nothing else.

It would be nice to have this feature - right now, there is much manual work required to make it work for GameVault.

shakeyourbunny commented 1 week ago

You forgot to mention that your GameVault is primarily for meant illegal activities.

On the other hand, don't come around and begin to demand stuff how the things you want to use have to change and want to offload the work for your piracy application launcher to the original developer of the utility you want to use.

Please read the fine manual and options, you will see, that your things you want to do are already possible.

Also, using a fresh born github account for your demand does not make it better.

DrakeHamString commented 1 week ago

You forgot to mention that your GameVault is primarily for meant illegal activities.

A clear "no" at this point. I've bought the games in my GOG library and I want a better access to my games from my PCs in the local network than browsing through folders. GameVault gives you a nice list with Game Label Images and such.

begin to demand stuff

Its a feature request, not a demand. At the end the maintainer decides what to do

to offload the work for your piracy application

Still false accusation

Please read the fine manual and options, you will see, that your things you want to do are already possible.

I already did. There is no serious online documentation and the manual using man lgogdownloader does not provide information about stuff like ZIP compression. The manual itself is good, but for my needs I was not able to find something.

Also, using a fresh born github account for your demand does not make it better.

Weird way to say that my account is fresh born since its created in 2016 :P

shakeyourbunny commented 1 week ago

Please read the fine manual and options, you will see, that your things you want to do are already possible.

I already did. There is no serious online documentation and the manual using man lgogdownloader does not provide information about stuff like ZIP compression. The manual itself is good, but for my needs I was not able to find something.

zip (re)compression is not something that is in scope of a downloader. just script it.

ssokolow commented 1 week ago

piracy application

@shakeyourbunny I don't see how GameVault is appreciably different from how I keep an L:\Installers (full of legit GOG.com, Itch.io, Humble Bundle, etc. installers) on the HP system from 2012 that I repurposed as a "Windows 7 game console, except not a console" and then shared it via Windows File Sharing when I received an old Alienware PC and needed to kit it out as another such system for the living room TV. (C: is the 500GB SSD. L: is the 1-2TB rotating drive, depending on which of the two machines you're talking about.)

Hell, I remember when that thing was first announced. It reminded me that, one of these days, I really need to get back to working on my PyQt-based Playnite-esque test platform for heuristics that can build the highest-possible quality launcher list without relying on any external service.

If anything, you being so eager to jump to that accusation makes me suspect you of accusing others of what you're engaged in.

shakeyourbunny commented 1 week ago

piracy application

@shakeyourbunny I don't see how GameVault is appreciably different from how I keep an L:\Installers (full of legit ... If anything, you being so eager to jump to that accusation makes me suspect you of accusing others of what you're engaged in.

If you look at the naming conventions of the documentation [1] and the example screenshots like [2], it does not look like an application that is really intended for hosting DRM-free games [3].

At least, these games shown in their showcases, are definitely ARE NOT DRM free games:

They are "DRM free" and playable through that launcher only, if they have been pirated.

GameVault also has also a standard common disclaimer found on many scene sites:

GameVault manages DRM-free games and is solely a tool to address this need. We are not responsible for the content or files users store or share.

When we say DRM-free games, we only mean games obtained legally. While GameVault can theoretically be used with illegally obtained games, we do not endorse or support piracy.

Users must be aware of and comply with copyright laws in their respective jurisdictions. We encourage responsible and legal use of GameVault. Unlawful use is strictly improper and unauthorized. [4]

These things lead to my conclusion that the self-description that its own usage description is deceptive and not telling the truth for what it is really intended for. Yes, it is usable for launching own games directly, but the main usage is hosting pirated games.

Coming back to the original issue: as already stated, lgogdownloader is capable of transforming the downloaded game name to something more akin that is requested, but the whole process should can done with a (rather simple) script.

[1] https://gamevau.lt/docs/server-docs/structure/#other-examples ( https://archive.ph/unezU ) [2] https://gamevau.lt/docs/client-docs/gui/#library-tab ( https://archive.ph/3wZS8 ) [3] https://gamevau.lt/docs/intro/#what-is-gamevault ( https://archive.ph/E4Oh6 ) [4] https://gamevau.lt/docs/intro/#legal-disclaimer ( bottom of link above )

ssokolow commented 1 week ago

If you look at the naming conventions of the documentation [...]

And yet they're asking for functionality to use it with LGOGDownloader... which requires a GOG.com account and downloads things that GOG.com account has legitimate access to.

Please follow "innocent until proven guilty".

shakeyourbunny commented 1 week ago

If you look at the naming conventions of the documentation [...]

And yet they're asking for functionality to use it with LGOGDownloader... which requires a GOG.com account and downloads things that GOG.com account has legitimate access to.

Please follow "innocent until proven guilty".

I already said that lgogdownloader has capabilities with the name transformation feature and that zipping should be done with a script after downloading, so I did point out, what the OP can do with lgogdownloader.

He has two options: either download the offline installer or do a gog galaxy download (and zip the folder up).

ssokolow commented 1 week ago

I already said [...]

I don't dispute that answer. That's why I didn't say anything about it.

My point was "Please don't give hostile first impressions to visitors."

DrakeHamString commented 1 week ago

My point was "Please don't give hostile first impressions to visitors."

Thank you