SudeshKumarSK / microapp_webscrapping

0 stars 0 forks source link

use startwith instead of in for URL validation #2

Open PandaWhoCodes opened 3 years ago

PandaWhoCodes commented 3 years ago
    if(("https://" in url) or ("https://" in url)):
        url = url + '/'

what happens if I give you an URL that is like this

ashish.ch/?url=https://google.com

SudeshKumarSK commented 3 years ago

I guess my function will fail if the input is ashish.ch/?url= https://google.com or anything of this sort. I will come up with a logic for this. Thanks man !

On Tue, Nov 3, 2020 at 4:25 PM Thomas Ashish Cherian < notifications@github.com> wrote:

if(("https://" in url) or ("https://" in url)):
    url = url + '/'

what happens if I give you an URL that is like this

ashish.ch/?url=https://google.com

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SudeshKumarSK/microapp_webscrapping/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJRUBOTDTIKSVQC72L26ZZDSN7OTBANCNFSM4TIS4LNQ .