Sudha247 / ocaml-joy

MIT License
22 stars 14 forks source link

Illustrations for a rectangle and concentric circles with multiple circles #10

Closed nangahamandine closed 1 year ago

nangahamandine commented 1 year ago

I have added files in the example folder that have:

Find the results below:

Screenshot (215) Screenshot (216)

nangahamandine commented 1 year ago

@Sudha247 please verify my illustrations based on issue #3 I'd welcome whatever corrections you may have.

I'll proceed to work on the other illustrations that you listed while waiting for your reply

AryanGodara commented 1 year ago

Good work @nangahamandine !! Although, the .vscode directory shouldn't be here (it's part of your local IDE setup, and not a relevant part of the codebase) So please remove it in the next commit :)

nangahamandine commented 1 year ago

Below are images of the newly added illustrations: Screenshot (224) Screenshot (225) Screenshot (226) Screenshot (227) Screenshot (228)

nangahamandine commented 1 year ago

Apart from these illustrations, are there any other illustrations that you want me to do?

AryanGodara commented 1 year ago

Apart from these illustrations, are there any other illustrations that you want me to do?

No need for that @nangahamandine . I think you've already made great progress here :) It's nice to see that you're enthusiastic. Let's wait for @Sudha247 to take a proper look before merging this. But it's approved from my side.

Maybe you can start work on one of the new issues. Like tests

nangahamandine commented 1 year ago

Okay, awesome! Thank you for your guidance, I made all this progress thanks to the guidance of you and @Sudha247 :)

I'll start looking into other issues

nangahamandine commented 1 year ago

Thank you so much!!!