search

Sudha247 / ocaml-joy

MIT License
22 stars 14 forks source link

Normalized to a co-ordinate system with (0, 0) at the center #37

Closed nangahamandine closed 11 months ago

nangahamandine commented 11 months ago

I have made made some updates and implementations for this normalization to a co-ordinate system with (0, 0) at the center, based on issue #36 The implementations work fine so far. Please review to check if I did it correctly.

nikochiko commented 11 months ago

After your changes, can you also go through the Joy examples/tests to make sure they look the same as before. If some examples break, make a note of them and let us know here.

nangahamandine commented 11 months ago

Thank you for all the corrections. I'll update the code with all the above changes and do the tests

nangahamandine commented 11 months ago

@nikochiko I've updated the shape.ml file based no the changes you requested. I ran the dune runtest command and got no errors. The shapes too are displaying fine. Please review in case of any further corrections.

nangahamandine commented 11 months ago

@nikochiko, @Sudha247 Can you please reopen this PR, I'm trying to resolve the conflicts and it unexpectedly got closed..

nangahamandine commented 11 months ago

Thank you. I've updated the code based on the requested changes. Please review

nangahamandine commented 11 months ago

@nangahamandine nice work! i have some comments.

also, please try not to include other irrelevant changes in your PRs (in this case minor formatting changes). It makes it harder to find the relevant parts and review them.

It's okay this time, but please try to make a separate PR for such changes the next time.

Okay, understood