search

Sudha247 / ocaml-joy

MIT License
22 stars 14 forks source link

Set up CI #50

Closed Sudha247 closed 8 months ago

Sudha247 commented 1 year ago

To prevent build failures like the ones mentioned in #47, a CI will be useful. We can use GitHub actions and setup-ocaml for setting up the CI. Here's an example - https://github.com/ocaml-multicore/domainslib/blob/main/.github/workflows/main.yml.

TitilayoAdeyemi commented 1 year ago

Hi @Sudha247 Would be glad to work on this task. Can you assign it to me?

Sudha247 commented 1 year ago

Sure, please go ahead.

TitilayoAdeyemi commented 1 year ago

Thanks @Sudha247 I'd be on it

TitilayoAdeyemi commented 1 year ago

Hello @Sudha247 I have created a PR for this. Kindly review, I'd be expecting feedback. Thanks

nangahamandine commented 12 months ago

Great job @TitilayoAdeyemi! :) Thank you so much for your amazing contribution. Through this, I got to learn more about continuous integration.

I've done a little refactore of the CI in my present PRs so all the checks are passed now with no issues.

Sudha247 commented 12 months ago

@nangahamandine I noticed the CI failures due to dependencies on windows, too. Can you submit a separate PR for fixing it so we can review and merge it quickly, please?

nangahamandine commented 12 months ago

@nangahamandine I noticed the CI failures due to dependencies on windows, too. Can you submit a separate PR for fixing it so we can review and merge it quickly, please?

Okay, sure. I'll do that now.

nangahamandine commented 12 months ago

I've opened a PR for the refactor at PR #70 Please review.

Sudha247 commented 8 months ago

Fixed by #97.