Difficulty in rotating shapes with current rectangle representation

[nikochiko]

With the current representation of ellipse/rectangles, there's no way to rotate them. This is a problem, and we should correct for it.

We can keep the API the same but change the representation internally so that we can then rotate these shapes.

I'm thinking that we should use a general Polygon shape that would keep track of all points of the shape. In the rectangle constructor, we can calculate these initial points from the center, width, and height.

Rotating the ellipse would still be hard because the graphics library doesn't have an API that would account for its rotation. https://v2.ocaml.org/releases/4.03/htmlman/libref/Graphics.html

[nikochiko]

The problem is that the current rectangle representation only has a center, width, and height. It doesn't have room for information about its orientation.

Polygon as a collection of points is a general solution that will work with other polygons too.

@Sudha247 @AryanGodara

[nangahamandine]

With the current representation of ellipse/rectangles, there's no way to rotate them. This is a problem, and we should correct for it.

We can keep the API the same but change the representation internally so that we can then rotate these shapes.

I'm thinking that we should use a general Polygon shape that would keep track of all points of the shape. In the rectangle constructor, we can calculate these initial points from the center, width, and height.

Rotating the ellipse would still be hard because the graphics library doesn't have an API that would account for its rotation. https://v2.ocaml.org/releases/4.03/htmlman/libref/Graphics.html

Hi @nikochiko, @Sudha247, @AryanGodara

I have two propositions regarding the representation for the ellipse, it's rotation and complexity.

• Since the graphics library does not directly provide rotation for ellipses, we can simulate the rotation by redrawing the ellipse with a series of smaller line segments. This approach is not as efficient as directly rotating the ellipse, but it can produce the appearance of a rotated ellipse using the available OCaml Graphics API. I'm pretty sure that I can pull this off, to still look clean and accurate.
• To improve the rotation of the ellipse with the present representation, we can update the rotate function to use a matrix transformation, if possible.