search

Sudha247 / ocaml-joy

MIT License
22 stars 14 forks source link

radius -> multiply linearly by scaling factor #62

Closed nikochiko closed 7 months ago

nikochiko commented 1 year ago

In the scale transformation that we have, I had initially suggested that we scale the area by the scaling factor, but that's not as intuitive and also not compatible with SVGs.

We should instead scale linearly by the scaling factor as compared to scaling by its square root.

TitilayoAdeyemi commented 1 year ago

Hello @nikochiko I'd start working on this

nikochiko commented 1 year ago

@TitilayoAdeyemi please work on merging https://github.com/Sudha247/ocaml-joy/pull/41 first

TitilayoAdeyemi commented 12 months ago

Hello @nikochiko I have fixed the error in #41, I would like you to review it for me while I start working on this one. Thank you

TitilayoAdeyemi commented 11 months ago

Hello @nikochiko @Sudha247 I created a PR for this, also, I worked on #61 as well. Would really love for you to review the code. Thank you!