search

SudhanPlayz / Discord-MusicBot

An advanced discord music bot, supports Spotify, Soundcloud, YouTube with Shuffling, Volume Control and Web Dashboard with Slash Commands support!
https://musicbot.darrenofficial.com
Other
2.92k stars 2.84k forks source link

updated lavalink version, and added extra intructions to readme #1293

Closed chit-uob closed 2 months ago

chit-uob commented 2 months ago

Please describe the changes this PR makes and why it should be merged:

I updated the docker version of the lavalink, the previous version was updated and was unable to play youtube videos, this version has been tested and can play youtube videos.

I also added extra instruction in the readme, previously port was not mentioned, but it also needs to be changed, so I mentioned it there for better documentation.

Status and versioning classification:

Important.

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

This update brings forth refined configuration instructions and Docker enhancements for the Lavalink service. The guidance in README.md now aligns with Docker setup, focusing on configuring config.js. Meanwhile, docker-compose.yml adopts a new Docker image for the Lavalink service, ensuring compatibility and performance improvements.

Changes

File(s) Change Summary
README.md Updated instructions for configuring config.js to use the specified password and port in docker/application.yml.
docker-compose.yml Updated the Docker image tag to fredboat/lavalink:v3-update-lp for the lavalink service.

🐰✨ In the realm of code, where bits and bytes play,
A rabbit hopped by, with updates today.
"Lavalink's new tag!" it joyfully sang,
Configs adjusted, a harmonious clang.
Let servers now hum in a seamless array!
🎶🌟

Recent Review Details **Configuration used: CodeRabbit UI**
Commits Files that changed from the base of the PR and between 55335653da83720eae04830528ebccfacf4371ac and 19b93d9cacc4f371caa63f91d809054b24059efb.
Files selected for processing (1) * README.md (1 hunks)
Additional Context Used
LanguageTool (19)
README.md (19)
Near line 5: Unpaired symbol: ‘]’ seems to be missing Context: ...v5.1 Is in development! Go check it out [HERE!](https://github.com/wtfnotavailabl... --- Near line 11: This word is normally spelled with a hyphen. Context: ...ve your favorite songs in - Integrated self hosted Lavalink - Dedicated query channel - ... --- Near line 11: Possible spelling mistake found. Context: ...rite songs in - Integrated self hosted Lavalink - Dedicated query channel - More comm... --- Near line 14: Using many exclamation marks might seem excessive (in this case: 6 exclamation marks for a text that’s 1755 characters long) Context: ...ctionalities - And so much more to come! ## 🚧 | Prerequisites - [Node.js 16+]... --- Near line 19: Possible spelling mistake found. Context: ...6+](https://nodejs.org/en/download/) - [Lavalink Server](https://code.darrennathanael.co... --- Near line 20: Possible spelling mistake found. Context: ...m/how-to-lavalink) - You'll need to run `npm run deploy` or `yarn deploy`. to initia... --- Near line 20: This sentence does not start with an uppercase letter. Context: ... run `npm run deploy` or `yarn deploy`. to initialized the slash commands. _You ca... --- Near line 20: The verb after “to” should be in the base form as part of the to-infinitive. A verb can take many forms, but the base form is always used in the to-infinitive. Context: ...n `npm run deploy` or `yarn deploy`. to initialized the slash commands. _You can do this on... --- Near line 23: Possible spelling mistake found. Context: ... do this on your pc locally_ > NOTE: Lavalink is needed for music functionality. You ... --- Near line 23: Possible spelling mistake found. Context: ...nctionality. You need to have a working Lavalink server to make the bot work. ## 📝 | I... --- Near line 27: Possible spelling mistake found. Context: ...o v5 1. Download and configure v5 in a seperate folder. 2. Kick your bot out of your se... --- Near line 29: Possible spelling mistake found. Context: ...2. Kick your bot out of your server. 3. Reinvite the Bot with the right scopes. [Exam... --- Near line 30: Unpaired symbol: ‘]’ seems to be missing Context: ...nvite the Bot with the right scopes. [Example Invite URL (Change CLIENT_ID)](h... --- Near line 31: Possible spelling mistake found. Context: ...ope=bot%20applications.commands) 4. Run `npm run deploy` or `yarn deploy` to initial... --- Near line 36: Possible spelling mistake found. Context: ...gure the `config.js` file with the host `"lavalink"`, using the same `password` and `port`... --- Near line 38: Possible spelling mistake found. Context: ...lication.yml`. Build and start bot and lavalink ```sh docker-compose up -d --build ``` ... --- Near line 43: Possible spelling mistake found. Context: ...configured first. Don't forget to add a lavalink host Install all dependencies and depl... --- Near line 55: Unpaired symbol: ‘]’ seems to be missing Context: ...he bot ```sh node index.js ``` ## 📝 | [Support Server](https://discord.gg/sbySM... --- Near line 81: The official spelling of this programming framework is “Next.js”. Context: ... - [Express](https://expressjs.com/) - [Next JS](https://nextjs.org/) - [Next UI](https...
Additional comments not posted (1)
README.md (1)
`36-36`: Update the configuration instructions to match the new Lavalink settings. This change aligns the `config.js` setup with the `docker/application.yml`, which is crucial for ensuring that users correctly configure their environments.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.