v5 Lyrics - missing last line in every lyrics - Githubissues

SudhanPlayz / Discord-MusicBot

An advanced discord music bot, supports Spotify, Soundcloud, YouTube with Shuffling, Volume Control and Web Dashboard with Slash Commands support!

https://musicbot.darrenofficial.com

Other

2.97k stars 2.87k forks source link

v5 Lyrics - missing last line in every lyrics #928

Closed urbels closed 2 years ago

urbels commented 2 years ago

Every song lyrics requested are missing last line. Maybe API does it, cant check.

SudhanPlayz commented 2 years ago

@DarrenOfficial fix ur api

DarrenOfficial commented 2 years ago

man, blame genius

DarrenOfficial commented 2 years ago

Every song lyrics requested are missing last line. Maybe API does it, cant check.

can you provide the song that you're trying to search

DarrenOfficial commented 2 years ago

man, blame genius

my api just get's it from genius directly

brianferri commented 2 years ago

Is implementing a new lyrics grabber a possibility?

urbels commented 2 years ago

Every song lyrics requested are missing last line. Maybe API does it, cant check.

can you provide the song that you're trying to search

Just tried Nine Million Bicycles - Katie Melua. Last line bot reports is "And there are nine-million bicycles in Beijing". Actual last line is "And you know that I will love you till I die!".

DarrenOfficial commented 2 years ago

Every song lyrics requested are missing last line. Maybe API does it, cant check.

can you provide the song that you're trying to search

Just tried Nine Million Bicycles - Katie Melua. Last line bot reports is "And there are nine-million bicycles in Beijing". Actual last line is "And you know that I will love you till I die!".

I just checked, it seems like it's not just my api that are cutting the last line. check out: https://api.popcat.xyz/lyrics?song=Nine%20Million%20Bicycles%20-%20Katie%20Melua, https://some-random-api.ml/lyrics?title=Nine%20Million%20Bicycles%20-%20Katie%20Melua

I'm quite sure genius changes something at their end. I'll try to debug & fix it if possible.

JotaroKujo0525 commented 2 years ago

Uh @DarrenOfficial I did a thing where it uses lyrics-finder just like in v4, in my case, it's working pretty well, imma send the code to you in your dms

DarrenOfficial commented 2 years ago

Uh @DarrenOfficial I did a thing where it uses lyrics-finder just like in v4, in my case, it's working pretty well, imma send the code to you in your dms

v5 Would have use lyrics finder, but unfortunately it kinda sucks at finding lyrics.

DevAmiyo commented 2 years ago

Idk how to implement musixmatch api but musixmatch seems to have many lyrics genius doesn't. I've encountered it so many times Darren's api / genius just not having the lyrics I want but musixmatch does.

DarrenOfficial commented 2 years ago

musixmatch seems to have many lyrics genius doesn't.

You are correct, also you need to contact someone at musixmatch to get access to their API :kekw:. Also, from what I know musixmatch is expensive af https://about.musixmatch.com/business/pricing-plans

DarrenOfficial commented 2 years ago

Expensive, because licensing coverage cost a lot of money.

DevAmiyo commented 2 years ago

;-;

urbels commented 2 years ago

genius web seems to return all the lyrics. Could be just their api that cuts it off.

JotaroKujo0525 commented 2 years ago

so uh @urbels, is the bug fixed yet?

urbels commented 2 years ago

so uh @urbels, is the bug fixed yet?

no, nothing changed

Neko-Life commented 2 years ago

genius web seems to return all the lyrics. Could be just their api that cuts it off.

Ikr. @DarrenOfficial y u dum

DarrenOfficial commented 2 years ago

genius web seems to return all the lyrics. Could be just their api that cuts it off.

Ikr. @DarrenOfficial y u dum

no. there's nothing I can do, that's the way that I got the lyrics. I checked it.