Fixed potential package bundle clash on Android

SudoPlz / sp-react-native-in-app-updates

An in-app updater for the native version of your react-native app.

MIT License

491 stars 66 forks source link

Fixed potential package bundle clash on Android #1

Closed Gustash closed 4 years ago

Gustash commented 4 years ago

This PR fixes a potential bundle clash with other packages since it used the default package bundle name instead of a unique one.

It also applies Android Studio's linter recommended fixes and adds the proper repo link to package.json.

SudoPlz commented 4 years ago

The reason behind that was that we used a react-native module template, and totally missed those default values.

Thanks for taking care of that!

Gustash commented 4 years ago

@SudoPlz I have a few other improvements in mind, but I need to wait for Google to review a test app in the Play Store so I can test them in internal tracks

SudoPlz commented 4 years ago

I'll be super happy to hear them out.

Gustash commented 4 years ago

The main one is adding a listener to track the progress of the update, as that's something the native API provides