search

SudoPlz / sp-react-native-in-app-updates

An in-app updater for the native version of your react-native app.
MIT License
491 stars 66 forks source link

Fix incorrect getting version from siren check response #18

Closed ObidosDev closed 3 years ago

ObidosDev commented 3 years ago

In code someone tried to get the version as a field of boolean value

SudoPlz commented 3 years ago

Hey @ObidosDev did you test that? Is it working? I wonder how that laid in there for that long.

ObidosDev commented 3 years ago

@SudoPlz I did not test it, I just have done sync with right version of react-native-siren lib and check by console.log current response structure :)

ObidosDev commented 3 years ago

@SudoPlz have a chance to get it soon?

SudoPlz commented 3 years ago

Yep I'll take a look today.

On Mon, Apr 12, 2021, 11:26 AM Vitalii Obideiko @.***> wrote:

@SudoPlz https://github.com/SudoPlz have a chance to get it soon?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SudoPlz/sp-react-native-in-app-updates/pull/18#issuecomment-817602085, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXNXZAK7CZMUZA7RLGEIYTTIKVDVANCNFSM42UT5Y6Q .

SudoPlz commented 3 years ago

This should be fixed in 1.0.3 (Note that there's a breaking change on how you import the update type for android) but there are no typings and your compiler should complain if you don't import the right type. Check it out and let me know if everything works now.

ObidosDev commented 3 years ago

@SudoPlz looks like it was fixed in 1.0.3, but the typization is still not very good, but that's another story

SudoPlz commented 3 years ago

Glad to hear that @ObidosDev What's wrong with the typization? Types are working on my machine just fine. That being said, if you could open a PR I'd be happy to merge any fixes to types.

Thanks