search

SudoPlz / sp-react-native-in-app-updates

An in-app updater for the native version of your react-native app.
MIT License
491 stars 66 forks source link

feat: added auto curVersion with device info #20

Closed ShivamJoker closed 3 years ago

ShivamJoker commented 3 years ago

This PR makes the curVersion parameter optional as it takes the app version using rn-device-info.

Also mentioned in - #15

ShivamJoker commented 3 years ago

@SudoPlz can you please review the PR and let me know if there is any change required.

ShivamJoker commented 3 years ago

How should I test it ? I don't see any test files

SudoPlz commented 3 years ago

I mean locally (manually), using the example project. Also what's with the yarn file changes, was that intended?

Looking good so far.

ShivamJoker commented 3 years ago
image

I am getting this on android And ios build is failing for some reason (maybe due to latest xcode update)

ShivamJoker commented 3 years ago

Okay after fixing pods again it seems to work tested it with and without passing version. Hope now you can merge it

image
SudoPlz commented 3 years ago

Cool, thanks for the changes, looking good so far. Question, what's with the yarn file changes, was that intended?

ShivamJoker commented 3 years ago

I removed yarn files because I added it accidentally, seems you are using npm instead of yarn.

On Wed, May 5, 2021, 5:10 PM Ioannis Kokkinidis @.***> wrote:

Cool, thanks for the changes, looking good so far. Question, what's with the yarn file changes, was that intended?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SudoPlz/sp-react-native-in-app-updates/pull/20#issuecomment-832620589, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFVA4NWJL62MJWCAQHBQ37TTMEVCNANCNFSM44CUFJNQ .

SudoPlz commented 3 years ago

I still see yarn files in your pr

ShivamJoker commented 3 years ago

is it fine now ?

SudoPlz commented 3 years ago

There's still a .yarnrc file, could you please delete that too?

Thanks

ShivamJoker commented 3 years ago

@SudoPlz I have deleted it, it's actually in your repo.

SudoPlz commented 3 years ago

@ShivamJoker apologies I totally missed that.

Merging now.

SudoPlz commented 3 years ago

Released under 1.1.0

ShivamJoker commented 3 years ago

Released under 1.1.0

Wouldn't it be better to use github actions and connect release directly to npm ?

SudoPlz commented 3 years ago

Do you feel like creating a pr for that too?

ShivamJoker commented 3 years ago

@SudoPlz we are still needing to pass empty object, can you fix it ?

SudoPlz commented 3 years ago

@ShivamJoker that was just a typings issue. Fixed it on 1.1.1