Hello.
This package uses react-native-siren's performCheck function to check from the iTunes search API for an available update. This is done through the checkNeedsUpdate and startUpdate methods.
After bringing the country code filter function to react-native-siren, I saw that this functionality has been implemented and the dependency has been increased. But currently only checkNeedsUpdate benefits from the function, the startUpdate method has not been updated accordingly.
Note that without this fix on startUpdate the only country filter on checkNeedsUpdate is useless. In the readme's example the method invocation to startUpdate will trigger a new lookup request to iTunes without the country code, the app won't be found and the update prompt never shown. Obviously this is true for the iOS apps available only for selected countries.
This PR provides the necessary changes to take advantage of the country parameter and other optional parameters allowed by react-native-siren's promptUser function, such as versionSpecificOptions.
I also updated the types and the README.md with the description of the new parameters and a usage example.
Hello. This package uses react-native-siren's performCheck function to check from the iTunes search API for an available update. This is done through the checkNeedsUpdate and startUpdate methods.
After bringing the country code filter function to react-native-siren, I saw that this functionality has been implemented and the dependency has been increased. But currently only checkNeedsUpdate benefits from the function, the startUpdate method has not been updated accordingly. Note that without this fix on startUpdate the only country filter on checkNeedsUpdate is useless. In the readme's example the method invocation to startUpdate will trigger a new lookup request to iTunes without the country code, the app won't be found and the update prompt never shown. Obviously this is true for the iOS apps available only for selected countries.
This PR provides the necessary changes to take advantage of the country parameter and other optional parameters allowed by react-native-siren's promptUser function, such as versionSpecificOptions. I also updated the types and the README.md with the description of the new parameters and a usage example.
Referenced issue: #55 and #64