search

SudokuMonster / SukakuExplainer

Modification to Sudoku Explainer (SE) by Nicolas Juillerat to accommodate Sukaku (Pencilmark) Sudoku puzzles
GNU Lesser General Public License v2.1
71 stars 14 forks source link

UI changes #79

Closed 1to9only closed 4 years ago

1to9only commented 4 years ago

For some time, I've changed the UI for personal taste, e.g. I diskile the vanilla sudoku light turquoise blocks background color and the red region highlight! I tend to change other things on every private builds:

The UI currently look like this: Skyscraper

This new UI may not be everyone's cup of tea! So it can be discussed here. If there is consensus, I'll upload the code. It's OK if the answer is no (issue can be closed), as I'm happy to carry on with my private builds. Merry Xmas all.

1to9only commented 4 years ago

Another view: Skyscraper2

1to9only commented 4 years ago

What the vanilla sudoku looks like: Vanilla

SudokuMonster commented 4 years ago

To be honest 1to9only I would prefer a consensus on this as some of the changes are not my personal preference but I can't say no either (Not my project alone) … I like the softer background colours for DG but I actually like that light turquoise blocks background color and the red region highlight! I feel that it added a bit fresher look with the new font as well.

Will post the colour suggestions on the forum and await reply … We could even have several UI preferences (yours and mine) … a bit more coding but should cater for everybody

1to9only commented 4 years ago

Just going by @SudokuMonster's comments above, I'm more likely to not proceed with this, as I'm OK going with my private builds. I don't want the situation reversed! where these changes are made, and others have to reverse them to suit...

SudokuMonster commented 4 years ago

Can't you have your own entry in the Look & Feel menu? With a bit of coding your preference would be always their to appear by a menu selection! I think you (and probably me) deserve a bit of immortality for all the work we put in it. The UI changes would cost very little in terms of overall performance. I can't see why even without having a consensus) we couldn't add another option in the Look & feel menu with all preferences that you would like to see!

1to9only commented 4 years ago

From #84, the setGrid change: engine.setGrid(sudokuPanel.getSudokuGrid()); would have been a pre-requisite. The comment from #84: I would still for the time being keep the grid clearing with every variant change & some options selection as referencing a problem or solving technique would be easier. means the UI changes are unlikely to happen. Closed.

SudokuMonster commented 4 years ago

I still can't see why we couldn't have different themes / colour change preferences as GUI options. I'm guessing you have looked into that and found it either tricky or in conflict with some of what I mentioned before. I haven't investigated this so I'm not sure what the problem is! I'm happy to look into this again if needed!

SudokuMonster commented 4 years ago

With the ability to load() and save() tested and working. I can't see why we couldn't have a theme with panel preferences which can be selected from a themes (sub)menu. The Theme preferences defaults would be in Settings & can be accessed via Settings.getInstance()