Open yeswolf opened 1 year ago
Corrected. Extracted tokens from regular expressions
I've tried HTML as an example and I see keywords that aren't from HTML bundle. Like - type 't' and have tamil
suggested. Are we sure that when concrete language is selected only keywords from this language are here? Latest master.
Example:
String html = "<p>some paragraph</p><i></i><t>";
To get keywords, I parse textmate
regular expressions. They contain these side words. For example, tamil
is found in the following regular expression for HTML:
(?xi) (?<![-])
(arabic-indic | ... | tamil | ... | urdu)
(?![-])
I see keywords from Java
appeared in html
Corrected it so that words from other languages would not be present. Changed the way words are extracted. For some languages there were built-in keywords in IDE, I took them from there. For the rest I parsed regular expressions.
For HTML
it looks like this. But words for it have to be extracted in a different way.
However, there may still be words that are not keywords, but are contained in regular expressions. For example, there are languages here.
It might be better to fill in keywords by hand. And if the user adds his textmate bundle
, then provide UI
for him to add keywords. What do you think?
I've merged
Looks like there is a keyword completion contributor for specific TM langauge, as it works in the separate file - we should use the same in the injected fragment instead of something general that's used now.
Correct:
Incorrect: