SufficientlySecure / document-viewer

Document Viewer is a highly customizable document viewer for Android.
GNU General Public License v3.0
524 stars 155 forks source link

Redesign "view options" menu into a dialog #240

Open ericwa opened 7 years ago

ericwa commented 7 years ago

The "view options" menu could make better use of the available space by changing from a menu into a special-purpose dialog.

Some ideas:

For reference here are some screenshots of current DV, Kindle, and Play Books:

screenshot_2017-02-05-14-06-49-841_org sufficientlysecure viewer

Kindle: screenshot_2017-02-05-13-34-34-793_com amazon kindle

Play books: screenshot_2017-02-05-13-31-07-126_com google android apps books

screenshot_2017-02-05-13-31-13-678_com google android apps books

Daedalon commented 7 years ago

Generally speaking, I like the menu as it is, or at least haven't considered it negatively before seeing this thread. I've only ever felt the temptation to try only a fraction of the options available though.

If we want to clean up, the simplest step would be if we can remove some options completely from here. Do all of these serve a purpose? At least I've never used Full screen from here, because tapping anywhere in the book switches between full screen. Show Title is another one I haven't used either (it also happens to be inconsistent in the capitalization viz the other menu items). Also, what about Set as thumbnail? Didn't even notice that option before, and don't immediately have an idea what would I want to use it for.