SufficientlySecure / document-viewer

Document Viewer is a highly customizable document viewer for Android.
GNU General Public License v3.0
517 stars 155 forks source link

Cannot swipe forward/back when viewing portrait document on landscape screen under "Fit width (single page)" rules #55

Open lofidevops opened 9 years ago

lofidevops commented 9 years ago

Steps to reproduce:

What should happen:

What happens instead:

Notes:

tuxor1337 commented 9 years ago

This is not a problem of portrait/landscape. And you seem to misunderstand the "hand" icon. The icon in the bottom right corner indicates, whether you are in the page-flip mode (where swiping left/right will change pages) or in the "hand" mode, where you can navigate around inside a (zoomed) page.

From my understanding, you cannot switch manually between these modes, but the first mode is always used, when the whole page fits on the screen (indicated by a double arrow in the bottom left corner). Otherwise the hand mode is used.

The "hand" icon itself does not have the purpose of pressing on it as you describe it. Instead the behaviour you describe seems to come from the standard tap areas, i.e. tapping in the bottom or top area will flip pages.

So your bug report is at first about communicating what I wrote in a more efficient way to the user. Whether we really want to implement some new swipe detection in "hand" mode, seems not so clear to me: Usually, tap configurations are meant to serve this purpose...

lofidevops commented 9 years ago

I understand and have tested the top/bottom tap behaviour, which works, thanks!

Perhaps an unobtrusive overlay on the tapping area would work? Probably easier said than done :) I'm leaving this ticket if you will be using it for any work on refinements / communicating details. If not, I'm happy to close it as my original request was resolved.

ericwa commented 8 years ago

I hit a similar issue on a comic book with varying page sizes.

Most of the time I had the <-> icon in the lower right corner, and I could flip pages by swiping left/right.

But some pages were taller than my tablet screen, and I got the hand icon in the lower right corner. On those pages the left/right swipe gesture no longer works.

Ideas to fix this: