search

SufficientlySecure / document-viewer

Document Viewer is a highly customizable document viewer for Android.
GNU General Public License v3.0
519 stars 155 forks source link

Fullscreen: status bar and soft keys remain on Nexus10 CyanogenMod #56

Open taro-k opened 9 years ago

taro-k commented 9 years ago

Hi. as you know, the notification bar at the top and virtual buttons at the bottom remains in the fullscreen mode. I hope fullscreen mode were fully fullscreen without notification bar and virtual buttons.

tuxor1337 commented 9 years ago

Actually, fullscreen mode is supposed to suppress the notification bar and the virtual buttons. I cannot reproduce your issue on Android 4.4 or 4.1, so which version of Android are you testing this with?

taro-k commented 9 years ago

@tuxor1337 thx! It's CyanogenMod 10.1.3-manta (stable) on Nexus 10. (This CyanogenMod is based on Android 4.2.2) If anything I should check or try, please let me know.

taro-k commented 9 years ago

On the same Nexus 10 (manta), I also tried

but I still see the same problem. If anything I can help for debugging, please let me know! thx

taro-k commented 9 years ago

Other app like "Pocket" works with really full screen mode.

tuxor1337 commented 9 years ago

So it seems to me like this is either tablet or specifically Nexus 10 related. Please report back if you find out that more devices are affected. At the moment, I don't see anything I could do - in particular, because the ui of document viewer has more flaws that need to be addressed and I'm not exactly into android ui coding...

taro-k commented 9 years ago

I guess it's not only on Nexus 10 but also other devices without physical button area. Which devices are you running for tests? I will also test on Galaxy Nexus whose buttons are virtual as well later.

By the way, IMO document-viewer is definitely the best PDFed book reader. I am respecting the work. Other "flaws" are too minor for me. Even not flaw. But this topic is very important for UX.

tuxor1337 commented 9 years ago

I'm running tests mainly on a Motorola Photon Q running Android 4.4. But in addition to that, I'm using Document Viewer on my Icarus Illumina E653 ebook reader (running Android 4.2). Both devices' UX feature virtual buttons. And on both devices fullscreen mode works as it's supposed to.

Serious flaws are: It's not possible to set a tap area that navigates to the next page or at least that scrolls by a sensible amount (like the size of one screen/view port). There's no way to turn pages when in single page mode and the page does not fit on the screen. Some parts of the user interface are ugly as hell (table of contents, go to page, manage tap behaviour, book shelf, manage key short cuts) and the settings menu is as confusing as can be. Furthermore the UI code seems really ugly to me, since there are dozens of exceptions for old versions of Android (starting from 1.7!) and in many cases existing Android API has been ignored in favour of own implementations of standard UI features.

taro-k commented 9 years ago

Thank you for your reply. I confirmed my guess was wrong, that is, Galaxy Nexus with Cyanogenmod goes to fully full screen mode although it's virtual button model.

taro-k commented 9 years ago

After exploring some information about fullscreen, I found Cyanogenmod (11) has "Immerse function"! Practically, it's enough for me so far. But please let me keep this issue open for solving in the future.

Also, I will update the title of this issue again according to Android standards: notification area -> status bar virtual buttons -> soft keys

There's no way to turn pages when in single page mode and the page does not fit on the screen.

Yeah, I really hope this function next!

taro-k commented 9 years ago

Tentative solution of mine: http://www.guidingtech.com/31618/enable-immersive-mode-android/

  1. Expanded Desktop In Custom ROM