SuffolkLITLab / ALActions

A github repo with all of the shared actions used in Assembly Line Projects
1 stars 0 forks source link

Update pythontests to use 3.10 by default #10

Closed BryceStevenWilley closed 1 year ago

BryceStevenWilley commented 1 year ago

Can also add an argument that lets people use any version of python they want, for testing with older DAs. We'll still only test on 3.10.

BryceStevenWilley commented 1 year ago

Fixed in https://github.com/SuffolkLITLab/ALActions/commit/92741b239f6e1d11a5887b2c326c44a38ad2376f. I think I've changed my mind about giving a parameter though; the last DA version that could run 3.8 was 1.4.54, 3 months ago, and 3.10 has been default since 1.4.0 (over a year ago). I don't think we'd encourage others to use such old versions, so I don't think testing against them is necessary either. Maybe we'll have to run into this again with the next python update, but I do like the consistency of these actions, and adding a lot of input params for others to use defeats that purpose.