search

SuffolkLITLab / ALActions

A github repo with all of the shared actions used in Assembly Line Projects
1 stars 0 forks source link

action to auto deploy to a specified DA server #18

Open nonprofittechy opened 1 year ago

nonprofittechy commented 1 year ago

Related to #7 but does not completely close

nonprofittechy commented 11 months ago

I missed this one, but LGTM!

TBH, I don't know if we need both a playground install and a package install; the playground install can only be in the testing API key's account, which I wouldn't think people would be logged into most of the time, and a new playground pull would take about the same amount of time as logging in and out to another account and navigating to that playground. But I can see a use I guess.

The purpose of the playground install is to give people who have only one server a way to have a "testing" link for new packages, since playgrounds are the only real way Docassemble gives you to install multiple versions of an interview. While prod/dev is what I always recommend, for people doing internal only automations, this gives at least some of the benefit at a relatively lower risk.

My only other concern is if you want to use bash long term; my first approach was in python, and if we don't care about the update state (like this one does), it's about the same length.

Fair; I do like using just one language for simplicity, but my thought was it might be helpful to avoid depending on Python for these simple API calls. Maybe a silly concern since many of the other actions already depend on it.

I need to test this again before merging. I think it was suffering from the DA bug where Python modules weren't getting installed via the API, because the version numbers weren't updating from package management when this action was run in my tests a few weeks ago.

samglover commented 7 months ago

@nonprofittechy Just reminding you to take another look at this and merge if you are satisfied.