search

SuffolkLITLab / ALKiln

Integrated automated end-to-end testing with docassemble, puppeteer, and cucumber.
https://assemblyline.suffolklitlab.org/docs/alkiln/intro
MIT License
14 stars 4 forks source link

PLAYGROUND_* inputs aren't actually required #739

Closed BryceStevenWilley closed 1 year ago

BryceStevenWilley commented 1 year ago

GitHub will happily still run if you don't give them, (and works just fine: see https://github.com/SuffolkLITLab/docassemble-AssemblyLine/blob/f70ded5c029efd82e8d354d650fa02066422db8f/.github/workflows/run_form_tests.yml#L34-L36 ) but it does give erraneous warnings in VSCode, if you have the GitHub actions extension.

Haven't changed the CHANGELOG, since this doesn't actually change any functionality.

BryceStevenWilley commented 1 year ago

This looks good. These could actually be removed - they were replaced by the API key, and that's when this was actually a breaking change

They're removed now! Didn't realize we don't use them at all anymore.

plocket commented 1 year ago

Looks good, thanks!