SuffolkLITLab / ALKiln

Integrated automated end-to-end testing with docassemble, puppeteer, and cucumber.
https://assemblyline.suffolklitlab.org/docs/alkiln/intro
MIT License
14 stars 4 forks source link

Hotfix combobox plus hidden field under date field #746

Closed plocket closed 1 year ago

plocket commented 1 year ago

In this PR, I have:

Reason for this PR

A user reported that setting a combobox field wasn't working. This ended up being multifactorial.

  1. Because of DOM issues (new?), we weren't getting the variable name of the combobox fields.
  2. There was a date field above the combobox. The combobox's hidden field was being filled in first, which triggered the date field to show its calendar popup. I believe the popup ate the input for the combobox.

Skipping hidden fields might be a problem when we get to the current random input implementation, but still feels like the right way to go. We should instead always avoid filling in hidden fields.

Also, I had to deactivate the test for a11y because of the reasons I brought up in its comments and in https://github.com/SuffolkLITLab/ALKiln/issues/744.

Links to any solved or related issues

N/A

Any manual testing I have done to ensure my PR is working

No. The manual tests did not surface the behavior.

plocket commented 1 year ago

We'll have to work out accessibility failures as one of the next items.