SuffolkLITLab / ALKiln

Integrated automated end-to-end testing with docassemble, puppeteer, and cucumber.

https://assemblyline.suffolklitlab.org/docs/alkiln/intro

MIT License

14 stars 4 forks source link

Remove radio button changes #806

Closed plocket closed 10 months ago

plocket commented 10 months ago

I think we should also just get rid of the back button presses completely for the original PR, but this is one step forward.

[Updated] ~Note: This is failing because of that one error message test. When we rebase onto master on the original branch, we can easily fix this. I might actually go rebase that now and then rebase this again depending on how snarled it gets.~

In this PR, I have:

[x] Added tests for any new features or bug fixes (if relevant)
N/A [ ] Added my changes to the CHANGELOG.md at the top, under the "Unreleased" section
N/A [ ] Ensured issues that this PR closes will be automatically closed

Reason for this PR

Skip radio button fixes for random input tests for now. Pass tests.

~### Links to any solved or related issues~

~### Any manual testing I have done to ensure my PR is working~

BryceStevenWilley commented 10 months ago

637 is the tracking issue for the removed code btw.

I think we should also just get rid of the back button presses completely for the original PR

I don't think so. Back buttons don't undo external network calls or saving things to Redis, so making sure programs can handle (or least don't crash) when users press back buttons is still important.