SuffolkLITLab / ALKiln

Integrated automated end-to-end testing with docassemble, puppeteer, and cucumber.
https://assemblyline.suffolklitlab.org/docs/alkiln/intro
MIT License
14 stars 4 forks source link

Step: I tap the element using selector (without navigating) #834

Closed plocket closed 8 months ago

plocket commented 8 months ago

Currently that Step always expects navigation. [We've opted not to making a breaking change, but instead tweak the Steps a bit.]

~What I really want to do is change that Step to not navigate and make a new step that ends with "to navigate" or "to go to another/the next page".~

~This would be a breaking change, but I want to check with folks whether they use that step yet at all. If not, we can possibly change that step so it doesn't navigate without changing major versions. Otherwise we have to make a new Step with extra text that I don't appreciate.~

This would be a good opportunity to move "waiting to navigate" into its own function in scope.js. Right now it's in the AfterStep function.

plocket commented 8 months ago

Maybe we can make this sentence seem more normal by making things "worse". We use two "new" sentences instead of one:

  1. I tap ...element and stay on the same page
  2. I tap ...element and go to a new page

Under the hood, the second one doesn't do anything different than the default behavior and if you leave them both off then the default behavior still happens. Old tests will still pass and these two Steps will be together in the documentation, so they're awkward, but they'll make sense in context with each other.