SuffolkLITLab / ALKiln

Integrated automated end-to-end testing with docassemble, puppeteer, and cucumber.
https://assemblyline.suffolklitlab.org/docs/alkiln/intro
MIT License
14 stars 4 forks source link

Close #582, implement 2-column Story Tables with no trigger var #850

Closed plocket closed 6 months ago

plocket commented 6 months ago

In this PR, I have:

Reason for this PR

Allow authors to avoid proxy variables and their complications in Story Tables. This means a 2-column layout where the var column never contains x, i, etc, just the name of the actual variable that needs to be set.

It does require the author to put new HTML in their interview:

<div id="alkiln_proxy_var_values"
      data-generic_object="${ encode_name(str( x.instanceName if defined('x') else '' )) }"
      % for letter in [ 'i', 'j', 'k', 'l', 'm', 'n' ]:
      data-index_var_${ letter }="${ encode_name(str( value( letter ) if defined( letter ) else '' )) }"
      % endfor
      aria-hidden="true" style="display: none;"></div>

Links to any solved or related issues

Closes #582 - 2 column table Closes #573 for now, shortening the message a little. We'll work more on error messages another time. Closes #452 for now. Reduces the number of times we show this error message.

Also:

Any manual testing I have done to ensure my PR is working

None on the final product

plocket commented 6 months ago

The Playground test is failing because of the feature test with "Sr", but that test no longer exists on this repo. Wat.