SuffolkLITLab / ALKiln

Integrated automated end-to-end testing with docassemble, puppeteer, and cucumber.
https://assemblyline.suffolklitlab.org/docs/alkiln/intro
MIT License
14 stars 4 forks source link

Replace use of env vars with inputs instead #868

Open plocket opened 4 months ago

plocket commented 4 months ago

Proposal

I think we can trade out env vars for just (multiline) inputs. We can keep the current behavior around so there's no breaking change.

Why

Env vars have always felt kind of amorphous and half-formed to me. They contain very little information about themselves. I also don't think they were intended for this. They feel like the wrong fit for the purpose.

How

We'd parse strings for 2 different inputs:

with:
  ALKILN_SENSITIVE_TEST_VARIABLES: |
    foo: ${{ secrets.FOO }}
  ALKILN_PUBLIC_TEST_VARIABLES: |
    bar: bar

Are there downsides to this?