SuffolkLITLab / ALKiln

Integrated automated end-to-end testing with docassemble, puppeteer, and cucumber.
https://assemblyline.suffolklitlab.org/docs/alkiln/intro
MIT License
14 stars 4 forks source link

Close #831, allow author to delete interviews from interview list #921

Closed plocket closed 2 months ago

plocket commented 2 months ago

In this PR, I have:

Reason for this PR

Until now, interview sessions that the tests created were left on the server. Now, a test that logs in as a user can delete their interview session as long as the author also includes that user's API key in the "start interview" Step.

Adjusts repo's workflows and secrets to include new information. This means we should probably update the instructions for new collaborators. For the github_server workflow, that meant creating a low-level user in the new container to log in, and delete interviews, separately from the admin user. I currently don't remember what test that broke. It was something about the admin user being able to see all interviews and delete all interviews.

Also adjusts log code tests to ignore feature files, or any files in the ALKilnTests folder, when checking for codes. That way, our feature tests can check that output/reports have the correct log codes. Still need to change "tests/log_codes/check_codes.sh" to "check_codes.sh" to work properly in GitHub workflows.

Switched to adding our own users[0] question because of changes in Assembly Line.

Links to any solved or related issues

Closes #831

Any manual testing I have done to ensure my PR is working

Visually confirmed that interviews were created and then deleted on the server.