Log codes checking was a bit disjointed. It used a list of deleted log codes and a list of duplicate log codes. It checked for missing codes separately from duplicate or extra codes. It didn't have refinement - like the ability to check that only 2 of a log code was in the code so we would make sure not to add a 3rd one.
This just has a file containing a list of codes and how many of each should exist. It also is able to log the file paths of the appearance of the log code.
It does take a bit longer to run, though. In #920, there's a link to a repl.it that has an 'archive7_diff.sh' file that contains a potentially faster way to do this, though it would leave out the extra information about the file paths.
Links to any solved or related issues
Closes #920
Any manual testing I have done to ensure my PR is working
Lots of these:
Passing normally
Passing with a code that's been deleted
Failing with multiple missing codes because a code number was skipped
Fail with missing codes for a code being "accidentally" deleted in the code base
In this PR, I have:
Added tests for any new features or bug fixes (if relevant)Reason for this PR
Log codes checking was a bit disjointed. It used a list of deleted log codes and a list of duplicate log codes. It checked for missing codes separately from duplicate or extra codes. It didn't have refinement - like the ability to check that only 2 of a log code was in the code so we would make sure not to add a 3rd one.
This just has a file containing a list of codes and how many of each should exist. It also is able to log the file paths of the appearance of the log code.
It does take a bit longer to run, though. In #920, there's a link to a repl.it that has an 'archive7_diff.sh' file that contains a potentially faster way to do this, though it would leave out the extra information about the file paths.
Links to any solved or related issues
Closes #920
Any manual testing I have done to ensure my PR is working
Lots of these: