SuffolkLITLab / courtformsonline.org

Code for courtformsonline.org index of guided interviews. This replaces the "massaccess" repo
https://courtformsonline.org
MIT License
2 stars 0 forks source link

Prod var env #40

Closed jtmst closed 2 months ago

jtmst commented 3 months ago

Move token value to inline, env not loading for client components after build

gitguardian[bot] commented 3 months ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [11646847](https://dashboard.gitguardian.com/workspace/175765/incidents/11646847?occurrence=145829216) | Triggered | Generic High Entropy Secret | c5a431e3ca51040a8d2dcd3f725eccd3ba07767b | .env | [View secret](https://github.com/SuffolkLITLab/courtformsonline.org/commit/c5a431e3ca51040a8d2dcd3f725eccd3ba07767b#diff-e9cbb0224c4a3d23a6019ba557e0cd568c1ad5e1582ff1e335fb7d99b7a1055dR1) | | [11646847](https://dashboard.gitguardian.com/workspace/175765/incidents/11646847?occurrence=145954907) | Triggered | Generic High Entropy Secret | dc9c6d3f3f48378da916607c19bcbdcef08f3388 | .env | [View secret](https://github.com/SuffolkLITLab/courtformsonline.org/commit/dc9c6d3f3f48378da916607c19bcbdcef08f3388#diff-e9cbb0224c4a3d23a6019ba557e0cd568c1ad5e1582ff1e335fb7d99b7a1055dL1) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

nonprofittechy commented 2 months ago

@colarusso can you confirm we can set a referer restriction for SPOT such that it's fine to include the API key here in the source? It's what we did before...

colarusso commented 2 months ago

We actually don't have a referrer restriction in place. All the live implementations aside from courtformsonline keep it hidden. We got away with it in the source there just because. :/ Also, the demo keys that are public are throttled.

jtmst commented 2 months ago

We actually don't have a referrer restriction in place. All the live implementations aside from courtformsonline keep it hidden. We got away with it in the source there just because. :/ Also, the demo keys that are public are throttled.

There isnt a great way to hide these without putting some kind of server in place since its all static output. Even if its tucked in a ENV file its still visible to anyone looking at the request from their browser.

colarusso commented 2 months ago

Agreed. Another consequence of this is the site cobbled together during the pandemic.

nonprofittechy commented 2 months ago

Agreed. Another consequence of this is the site cobbled together during the pandemic.

@colarusso how feasible is it to add referer restrictions to the API keys for SPOT?