search

SuffolkLITLab / docassemble-ALDashboard

A frontend to a few common administrative backend functions that aren't built-in to Docassemble
MIT License
8 stars 0 forks source link

basic font install support #106

Closed nonprofittechy closed 1 year ago

nonprofittechy commented 1 year ago

Fix #16

Feel free to skip review if you don't have time.

nonprofittechy commented 1 year ago

LGTM.

Not sure if you've seen https://demo.docassemble.org/run/demo/fontlist/#/1, but TBH, it's a bit more readable than the component you have here, even though it's still useful (have to think of and rely on in-page search).

Hmm. That is way better actually. I don't know that I'll change it now though, but I'll open an issue to switch it at some point.

I also can't seem to actually use my font once it's installed (trying to follow https://docassemble.org/docs/documents.html#rendering%20font). But that's either a me problem, or a docassemble problem, so it shouldn't block this.

It definitely works when I upload a new [DOCX template with the font and look at the generated PDF. (I checked by uploading to the Weaver as a quick way to experiment). It may only work in Libreoffice, because of the directory we install the font to.